Skip to content

feat!: Yolo object detection#987

Merged
msluszniak merged 16 commits intomainfrom
@bo/yoloObjectDetection
Mar 25, 2026
Merged

feat!: Yolo object detection#987
msluszniak merged 16 commits intomainfrom
@bo/yoloObjectDetection

Conversation

@benITo47
Copy link
Copy Markdown
Contributor

@benITo47 benITo47 commented Mar 20, 2026

Description

This PR adds yolo models and multi-method support to our ObjectDetection API.
Deduplication of common CV code will be done in a separate PR

Introduces a breaking change?

  • Yes
  • No

Type of change

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Documentation update (improves or adds clarity to existing documentation)
  • Other (chores, tests, code style improvements etc.)

Tested on

  • iOS
  • Android

Testing instructions

  • Try running example apps with Yolo models
  • Run tests

Screenshots

Related issues

Closes #718

Checklist

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly
  • My changes generate no new warnings

Additional notes

@msluszniak msluszniak added the feature PRs that implement a new feature label Mar 20, 2026
@benITo47 benITo47 force-pushed the @bo/yoloObjectDetection branch from aec863e to 9b77da7 Compare March 20, 2026 13:46
@msluszniak msluszniak self-assigned this Mar 23, 2026
@msluszniak msluszniak changed the title @bo/yolo object detection feat!: Yolo object detection Mar 23, 2026
@msluszniak msluszniak marked this pull request as ready for review March 23, 2026 10:04
@msluszniak
Copy link
Copy Markdown
Member

Documentation CI fails because this PR needs to be committed: #1000. I will also add benchmarks for iOS. Other than that, please review this PR.

Copy link
Copy Markdown
Contributor

@NorbertKlockiewicz NorbertKlockiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks okay, I ran it on ios and android and it worked as expected, I think we could write some tests for a new parts of object detection API.

Copy link
Copy Markdown
Contributor

@NorbertKlockiewicz NorbertKlockiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@msluszniak msluszniak force-pushed the @bo/yoloObjectDetection branch from 2d33d1d to 7a0e899 Compare March 24, 2026 15:09
@msluszniak msluszniak requested a review from chmjkb March 24, 2026 18:57
Copy link
Copy Markdown
Collaborator

@chmjkb chmjkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll test the demo apps and once I finish i think its ready to 🚢

Copy link
Copy Markdown
Collaborator

@chmjkb chmjkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two more example app issues - I don't see any bounding boxes in the vision camera demo app. The normal object detection screen works just fine, besides this styling issue which we really need to fix, otherwise I'll go bald trying to click the run model button 😆(you can see it's covered by the navbar), and its not even clickable after i click on the model selector

IMG_9614.MOV

@msluszniak msluszniak requested a review from chmjkb March 24, 2026 20:44
Copy link
Copy Markdown
Collaborator

@chmjkb chmjkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The demo app works now, and the dropdown looks better, buf still using one+ 12 i see the navbar covering the run model button

Copy link
Copy Markdown
Collaborator

@chmjkb chmjkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@msluszniak msluszniak merged commit e3f886d into main Mar 25, 2026
5 checks passed
@msluszniak msluszniak deleted the @bo/yoloObjectDetection branch March 25, 2026 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature PRs that implement a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add YOLO support

4 participants