Skip to content

fix: remove CxxModuleWrapper include#993

Merged
chmjkb merged 2 commits intomainfrom
@chmjkb/rn-84-fix
Mar 24, 2026
Merged

fix: remove CxxModuleWrapper include#993
chmjkb merged 2 commits intomainfrom
@chmjkb/rn-84-fix

Conversation

@chmjkb
Copy link
Copy Markdown
Collaborator

@chmjkb chmjkb commented Mar 23, 2026

Description

This PR removes usage of a header which was removed in RN 84. The usage of this header, crashed compilation of Android apps using RN >= 84

Introduces a breaking change?

  • Yes
  • No

Type of change

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Documentation update (improves or adds clarity to existing documentation)
  • Other (chores, tests, code style improvements etc.)

Tested on

  • iOS
  • Android

Testing instructions

  • Create a bare RN app with RN 84
  • Verify Android compiles on this branch, but doesnt on 0.8.0-nightly-bf29217-20260323
  • Verify that this branch works also with RN 81

Screenshots

Related issues

Checklist

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly
  • My changes generate no new warnings

Additional notes

@chmjkb chmjkb self-assigned this Mar 23, 2026
@chmjkb chmjkb added the bug fix PRs that are fixing bugs label Mar 23, 2026
@msluszniak
Copy link
Copy Markdown
Member

We should add RN 84 to supported versions here: https://docs.swmansion.com/react-native-executorch/docs/next/other/compatibility from now.

@chmjkb chmjkb force-pushed the @chmjkb/rn-84-fix branch from 82e7b21 to 46eb51c Compare March 24, 2026 11:42
@chmjkb chmjkb merged commit b55a21f into main Mar 24, 2026
5 checks passed
@chmjkb chmjkb deleted the @chmjkb/rn-84-fix branch March 24, 2026 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug fix PRs that are fixing bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants