Skip to content

Commit 077f1dc

Browse files
committed
Update todo
1 parent 55994a0 commit 077f1dc

2 files changed

Lines changed: 2 additions & 1 deletion

File tree

packages/react-native-gesture-handler/android/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerDetectorView.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ class RNGestureHandlerDetectorView(context: Context) : ReactViewGroup(context) {
5656

5757
for (entry in changes) {
5858
if (entry.value == GestureHandlerMutation.Attach) {
59+
// TODO: Attach to the child when attached gesture is a NativeGestureHandler, track children changes then
5960
registry.attachHandlerToView(
6061
entry.key,
6162
this.id,

packages/react-native-gesture-handler/apple/RNGestureHandlerDetector.mm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ - (void)updateProps:(const Props::Shared &)propsBase oldProps:(const Props::Shar
124124
NSNumber *handlerTag = [NSNumber numberWithInt:handlerChange.first];
125125

126126
if (handlerChange.second == RNGestureHandlerMutationAttach) {
127-
// TODO: Attach to the child when NativeGestureHandler remounts, track children changes?
127+
// TODO: Attach to the child when attached gesture is a NativeGestureHandler, track children changes then
128128
[handlerManager.registry
129129
attachHandlerWithTag:handlerTag
130130
toView:self

0 commit comments

Comments
 (0)