Skip to content

Commit 2a6b0bd

Browse files
Copilotm-bert
andcommitted
Fix unresolved Copilot review issues: GitHub capitalization, grammar fixes
Agent-Logs-Url: https://github.com/software-mansion/react-native-gesture-handler/sessions/de39b400-f365-4486-ab65-f619debecb58 Co-authored-by: m-bert <63123542+m-bert@users.noreply.github.com>
1 parent ddb324b commit 2a6b0bd

5 files changed

Lines changed: 12 additions & 12 deletions

File tree

packages/docs-gesture-handler/docs/guides/troubleshooting.mdx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@ import TabItem from '@theme/TabItem';
1111

1212
Thanks for giving this library a try! We are sorry that you might have encountered issues though. Here is how you can seek help:
1313

14-
1. Search over the [issues on Github](https://github.com/software-mansion/react-native-gesture-handler/issues). There is a chance someone had this problem in the past and it has been resolved!
15-
2. When you are sure your problem hasn't been reported or was reported but the proposed solution doesn't work for you please follow [our issue reporting guidelines](#reporting-issues).
14+
1. Search over the [issues on GitHub](https://github.com/software-mansion/react-native-gesture-handler/issues). There is a chance someone had this problem in the past and it has been resolved!
15+
2. When sure your problem hasn't been reported or was reported but the proposed solution doesn't work for you please follow [our issue reporting guidelines](#reporting-issues).
1616
3. You can try seeking help on [Software Mansion Discord](https://discord.com/invite/VemJ4df8Yr).
1717
4. If you feel like reading the source code we highly recommend it, as this is by far the best resource and gives you the most up to date insights into how the library works and what might be causing the bug.
1818
5. If you managed to find the solution consider [contributing](/docs/#contributing) a fix or update our documentation to make this information easier to find for others in the future.
@@ -22,7 +22,7 @@ Thanks for giving this library a try! We are sorry that you might have encounter
2222
This library is maintained by a very small team. Please keep this in mind when reporting issues, as we may not be able to respond as quickly as you might expect. We strive to address all problems as soon as possible, but our time is often constrained by other issues, features, or projects. To help us understand and address your issue more promptly, you can assist by:
2323

2424
- Making sure the issue description is complete. Please include all the details about your environment (library version, RN version, device OS, etc.).
25-
- It is best to provide an example app that reproduces the issue you are having. Put it up on [gist](https://gist.github.com/), [snack](https://snack.expo.io) or create a repo on Github – it doesn't matter as long as we can easily pull it in, run and see the issue.
25+
- It is best to provide an example app that reproduces the issue you are having. Put it up on [gist](https://gist.github.com/), [snack](https://snack.expo.io) or create a repo on GitHub - it doesn't matter as long as we can easily pull it in, run and see the issue.
2626
- Explain how you run your repro app and what steps to take to reproduce the issue.
2727
- Isolate your issue from other dependencies you might be using and make the repro app as minimal as possible.
2828
- If you have spent some time figuring out the root cause of the problem you can leave a note about your findings so far.

packages/docs-gesture-handler/docs/legacy-gestures/gesture-detector.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import OldAPIInfo from './\_shared/v2-info.md'
1111

1212
import FunctionalComponents from './\_shared/gesture-detector-functional1.md';
1313

14-
`GestureDetector` is the main component of the RNGH2. It is responsible for creating and updating native gesture handlers based on the config of provided gesture. The most significant difference between it and old gesture handlers is that the `GestureDetector` can recognize more than one gesture at a time thanks to gesture composition. Keep in mind that `GestureDetector` is not compatible with the [Animated API](https://reactnative.dev/docs/animated), nor with [Reanimated 1](https://docs.swmansion.com/react-native-reanimated/docs/1.x/).
14+
`GestureDetector` is the main component of the RNGH2. It is responsible for creating and updating native gesture handlers based on the config of the provided gesture. The most significant difference between it and old gesture handlers is that the `GestureDetector` can recognize more than one gesture at a time thanks to gesture composition. Keep in mind that `GestureDetector` is not compatible with the [Animated API](https://reactnative.dev/docs/animated), nor with [Reanimated 1](https://docs.swmansion.com/react-native-reanimated/docs/1.x/).
1515

1616
## Reference
1717

packages/docs-gesture-handler/docs/legacy-gestures/pan-gesture.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -136,15 +136,15 @@ Minimum distance the finger (or multiple fingers) need to travel before the gest
136136

137137
### `minPointers(value: number)`
138138

139-
A number of fingers that is required to be placed before the gesture can [activate](/docs/2.x/fundamentals/states-events#active). Should be a higher or equal to 0 integer.
139+
A number of fingers that is required to be placed before the gesture can [activate](/docs/2.x/fundamentals/states-events#active). Should be an integer greater than or equal to 0.
140140

141141
### `maxPointers(value: number)`
142142

143-
When the given number of fingers is placed on the screen and the gesture hasn't yet [activated](/docs/2.x/fundamentals/states-events#active) it will fail recognizing the gesture. Should be a higher or equal to 0 integer.
143+
When the given number of fingers is placed on the screen and gesture hasn't yet [activated](/docs/2.x/fundamentals/states-events#active) it will fail recognizing the gesture. Should be an integer greater than or equal to 0.
144144

145145
### `activateAfterLongPress(duration: number)`
146146

147-
Duration in milliseconds of the `LongPress` gesture before `Pan` is allowed to [activate](/docs/2.x/fundamentals/states-events#active). If the finger is moved during that period, the gesture will [fail](/docs/2.x/fundamentals/states-events#failed). Should be a higher or equal to 0 integer. Default value is 0, meaning no `LongPress` is required to [activate](/docs/2.x/fundamentals/states-events#active) the `Pan`.
147+
Duration in milliseconds of the `LongPress` gesture before `Pan` is allowed to [activate](/docs/2.x/fundamentals/states-events#active). If the finger is moved during that period, the gesture will [fail](/docs/2.x/fundamentals/states-events#failed). Should be an integer greater than or equal to 0. Default value is 0, meaning no `LongPress` is required to [activate](/docs/2.x/fundamentals/states-events#active) the `Pan`.
148148

149149
### `activeOffsetX(value: number | number[])`
150150

packages/docs-gesture-handler/versioned_docs/version-2.x/gesture-handlers/pan-gh.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,11 +54,11 @@ Minimum distance the finger (or multiple finger) need to travel before the handl
5454

5555
### `minPointers`
5656

57-
A number of fingers that is required to be placed before the handler can [activate](/docs/2.x/under-the-hood/state#active). Should be a higher or equal to 0 integer.
57+
A number of fingers that is required to be placed before handler can [activate](/docs/2.x/under-the-hood/state#active). Should be an integer greater than or equal to 0.
5858

5959
### `maxPointers`
6060

61-
When the given number of fingers is placed on the screen and the handler hasn't yet [activated](/docs/2.x/under-the-hood/state#active) it will fail recognizing the gesture. Should be a higher or equal to 0 integer.
61+
When the given number of fingers is placed on the screen and handler hasn't yet [activated](/docs/2.x/under-the-hood/state#active) it will fail recognizing the gesture. Should be an integer greater than or equal to 0.
6262

6363
### `activeOffsetX`
6464

packages/docs-gesture-handler/versioned_docs/version-2.x/gestures/pan-gesture.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -132,15 +132,15 @@ Minimum distance the finger (or multiple fingers) need to travel before the gest
132132

133133
### `minPointers(value: number)`
134134

135-
A number of fingers that is required to be placed before gesture can [activate](/docs/2.x/fundamentals/states-events#active). Should be a higher or equal to 0 integer.
135+
A number of fingers that is required to be placed before the gesture can [activate](/docs/2.x/fundamentals/states-events#active). Should be an integer greater than or equal to 0.
136136

137137
### `maxPointers(value: number)`
138138

139-
When the given number of fingers is placed on the screen and gesture hasn't yet [activated](/docs/2.x/fundamentals/states-events#active) it will fail recognizing the gesture. Should be a higher or equal to 0 integer.
139+
When the given number of fingers is placed on the screen and gesture hasn't yet [activated](/docs/2.x/fundamentals/states-events#active) it will fail recognizing the gesture. Should be an integer greater than or equal to 0.
140140

141141
### `activateAfterLongPress(duration: number)`
142142

143-
Duration in milliseconds of the `LongPress` gesture before `Pan` is allowed to [activate](/docs/2.x/fundamentals/states-events#active). If the finger is moved during that period, the gesture will [fail](/docs/2.x/fundamentals/states-events#failed). Should be a higher or equal to 0 integer. Default value is 0, meaning no `LongPress` is required to [activate](/docs/2.x/fundamentals/states-events#active) the `Pan`.
143+
Duration in milliseconds of the `LongPress` gesture before `Pan` is allowed to [activate](/docs/2.x/fundamentals/states-events#active). If the finger is moved during that period, the gesture will [fail](/docs/2.x/fundamentals/states-events#failed). Should be an integer greater than or equal to 0. Default value is 0, meaning no `LongPress` is required to [activate](/docs/2.x/fundamentals/states-events#active) the `Pan`.
144144

145145
### `activeOffsetX(value: number | number[])`
146146

0 commit comments

Comments
 (0)