Skip to content

Commit 8469c08

Browse files
committed
Use wantsEvents
1 parent 373041a commit 8469c08

2 files changed

Lines changed: 6 additions & 8 deletions

File tree

packages/react-native-gesture-handler/android/src/main/java/com/swmansion/gesturehandler/core/GestureHandler.kt

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -222,8 +222,6 @@ open class GestureHandler {
222222

223223
private fun isTrackingPointer(pointerId: Int) = trackedPointerIDs[pointerId] != -1
224224

225-
fun shouldHandleTouchEvent(event: MotionEvent) = isTrackingPointer(event.getPointerId(event.actionIndex))
226-
227225
private fun needAdapt(event: MotionEvent): Boolean {
228226
if (event.pointerCount != trackedPointersIDsCount) {
229227
return true
@@ -581,11 +579,12 @@ open class GestureHandler {
581579
onStateChange(newState, oldState)
582580
}
583581

584-
fun wantEvents(): Boolean = isEnabled &&
582+
fun wantsEvents(event: MotionEvent): Boolean = isEnabled &&
585583
state != STATE_FAILED &&
586584
state != STATE_CANCELLED &&
587585
state != STATE_END &&
588-
trackedPointersIDsCount > 0
586+
trackedPointersIDsCount > 0 &&
587+
isTrackingPointer(event.getPointerId(event.actionIndex))
589588

590589
open fun shouldRequireToWaitForFailure(handler: GestureHandler): Boolean {
591590
if (handler === this) {

packages/react-native-gesture-handler/android/src/main/java/com/swmansion/gesturehandler/core/GestureHandlerOrchestrator.kt

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -251,9 +251,7 @@ class GestureHandlerOrchestrator(
251251
preparedHandlers.sortWith(handlersComparator)
252252

253253
for (handler in preparedHandlers) {
254-
if (handler.shouldHandleTouchEvent(event)) {
255-
deliverEventToGestureHandler(handler, event)
256-
}
254+
deliverEventToGestureHandler(handler, event)
257255
}
258256
}
259257

@@ -276,7 +274,8 @@ class GestureHandlerOrchestrator(
276274
handler.cancel()
277275
return
278276
}
279-
if (!handler.wantEvents()) {
277+
278+
if (!handler.wantsEvents(sourceEvent)) {
280279
return
281280
}
282281

0 commit comments

Comments
 (0)