Skip to content

Commit 8598093

Browse files
Mateusz KiełbMateusz Kiełb
authored andcommitted
not using the GestureBasicSrc files other than for legacy and simplified pinch gesture boundary check
1 parent f201788 commit 8598093

5 files changed

Lines changed: 9 additions & 10 deletions

File tree

packages/docs-gesture-handler/docs/gestures/use-fling-gesture.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ sidebar_position: 6
88
import { webContainer } from '@site/src/utils/getGestureStyles';
99

1010
import FlingGestureBasic from '@site/static/examples/FlingGestureBasic';
11-
import FlingGestureBasicSrc from '!!raw-loader!@site/static/examples/FlingGestureBasicSrc';
11+
import FlingGestureBasicSrc from '!!raw-loader!@site/static/examples/FlingGestureBasic';
1212

1313

1414
import MouseButtonProp from './\_shared/mouse-button.mdx';

packages/docs-gesture-handler/docs/gestures/use-pan-gesture.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import { vanishOnMobile, appearOnMobile, webContainer } from '@site/src/utils/ge
1010
import useBaseUrl from '@docusaurus/useBaseUrl';
1111

1212
import PanGestureBasic from '@site/static/examples/PanGestureBasic';
13-
import PanGestureBasicSrc from '!!raw-loader!@site/static/examples/PanGestureBasicSrc';
13+
import PanGestureBasicSrc from '!!raw-loader!@site/static/examples/PanGestureBasic';
1414

1515
import BaseEventData from './\_shared/base-gesture-event-data.mdx';
1616
import BaseGestureConfig from './\_shared/base-gesture-config.mdx';

packages/docs-gesture-handler/docs/gestures/use-pinch-gesture.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ sidebar_position: 5
88
import { webContainer } from '@site/src/utils/getGestureStyles';
99

1010
import PinchGestureBasic from '@site/static/examples/PinchGestureBasic';
11-
import PinchGestureBasicSrc from '!!raw-loader!@site/static/examples/PinchGestureBasicSrc';
11+
import PinchGestureBasicSrc from '!!raw-loader!@site/static/examples/PinchGestureBasic';
1212

1313
<div className={webContainer}>
1414
<InteractiveExample

packages/docs-gesture-handler/docs/gestures/use-rotation-gesture.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ sidebar_position: 4
88
import { webContainer } from '@site/src/utils/getGestureStyles';
99

1010
import RotationGestureBasic from '@site/static/examples/RotationGestureBasic';
11-
import RotationGestureBasicSrc from '!!raw-loader!@site/static/examples/RotationGestureBasicSrc';
11+
import RotationGestureBasicSrc from '!!raw-loader!@site/static/examples/RotationGestureBasic';
1212

1313
<div className={webContainer}>
1414
<InteractiveExample

packages/docs-gesture-handler/static/examples/PinchGestureBasic.js

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,14 @@ import Animated, {
1313

1414
const clamp = (val, min, max) => Math.min(Math.max(val, min), max);
1515

16+
//FIXME: doesnt handle resizing
1617
export default function App() {
1718
const boxWidth = useSharedValue(100);
1819
const distanceDifference = useSharedValue(0);
1920

2021
const centerX = useSharedValue(0);
2122
const centerY = useSharedValue(0);
22-
const width = useSharedValue(0);
23-
const height = useSharedValue(0);
23+
const maxBoxSize = useSharedValue(0);
2424

2525
const pointerPositionX = useSharedValue(0);
2626
const pointerPositionY = useSharedValue(0);
@@ -42,13 +42,12 @@ export default function App() {
4242

4343
if (containerRef.current) {
4444
containerRef.current.measureInWindow((x, y, w, h) => {
45-
width.value = w;
46-
height.value = h;
45+
maxBoxSize.value = Math.min(w, h);
4746

4847
boxWidth.value = clamp(
4948
boxWidth.value,
5049
100,
51-
Math.min(w, h)
50+
maxBoxSize.value
5251
);
5352
});
5453
}
@@ -84,7 +83,7 @@ export default function App() {
8483
boxWidth.value = clamp(
8584
Math.max(distanceX, distanceY) * 2 + distanceDifference.value,
8685
100,
87-
Math.min(width.value, height.value)
86+
maxBoxSize.value
8887
);
8988

9089
pointerPositionX.value = event.absoluteX - centerX.value - 12;

0 commit comments

Comments
 (0)