Fix reattaching (#3960)

## Description

On both iOS and Android gesture reattaching did not work. The registry
did not check which detector was the gesture attached to before
detaching. As a result, when detaching from old detector it accidentally
detached the gesture from the new one.

## Test plan

Tested on the following example

<details>

```tsx

import { commonStyles } from '../common-app/src/common';
import React, { useState } from 'react';
import { View } from 'react-native';
import { GestureDetector, GestureHandlerRootView, useTapGesture } from 'react-native-gesture-handler';

export default function TapExample() {
  const [isTopActive, setIsTopActive] = useState(false);

  const tap = useTapGesture({
    onActivate: () => {
      console.log((isTopActive ? "top" : "bottom"), " clicked");
      setIsTopActive(prev => !prev);
    },
    disableReanimated: true
  })

  const noopGesture = useTapGesture({});
  return (
    <GestureHandlerRootView>
      <View style={commonStyles.centerView}>
        <GestureDetector gesture={isTopActive ? tap : noopGesture}>
          <View style={[commonStyles.box, { backgroundColor: isTopActive ? "red" : "blue" }]} />
        </GestureDetector>
        <GestureDetector gesture={isTopActive ? noopGesture : tap}>
          <View style={[commonStyles.box, { backgroundColor: isTopActive ? "blue" : "red" }]} />
        </GestureDetector>
      </View>
    </GestureHandlerRootView>
  );
}

```

</details>

Author: akwasniewski

packages/react-native-gesture-handler/android/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerDetectorView.kt

@@ -109,7 +109,7 @@ class RNGestureHandlerDetectorView(context: Context) : ReactViewGroup(context) {
     }
 
     for (tag in handlersToDetach) {
-      registry.detachHandler(tag)
+      registry.detachHandlerFromHostDetector(tag, this)
       nativeHandlers.remove(tag)
       attachedHandlers.remove(tag)
     }
@@ -134,7 +134,7 @@ class RNGestureHandlerDetectorView(context: Context) : ReactViewGroup(context) {
 
     for (child in virtualChildrenToDetach) {
       for (tag in attachedVirtualHandlers[child]!!) {
-        registry.detachHandler(tag)
+        registry.detachHandlerFromHostDetector(tag, this)
       }
       attachedVirtualHandlers.remove(tag)
     }
@@ -182,7 +182,7 @@ class RNGestureHandlerDetectorView(context: Context) : ReactViewGroup(context) {
       ?: throw Exception("Tried to access a non-existent registry")
 
     for (tag in nativeHandlers) {
-      registry.detachHandler(tag)
+      registry.detachHandlerFromHostDetector(tag, this)
       attachedHandlers.remove(tag)
     }
   }
@@ -197,13 +197,13 @@ class RNGestureHandlerDetectorView(context: Context) : ReactViewGroup(context) {
       ?: throw Exception("Tried to access a non-existent registry")
 
     for (tag in attachedHandlers.toMutableSet()) {
-      registry.detachHandler(tag)
+      registry.detachHandlerFromHostDetector(tag, this)
       attachedHandlers.remove(tag)
     }
 
     for (child in attachedVirtualHandlers) {
       for (tag in child.value) {
-        registry.detachHandler(tag)
+        registry.detachHandlerFromHostDetector(tag, this)
       }
       child.value.clear()
     }

packages/react-native-gesture-handler/android/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerRegistry.kt

@@ -78,8 +78,9 @@ class RNGestureHandlerRegistry : GestureHandlerRegistry {
   }
 
   @Synchronized
-  fun detachHandler(handlerTag: Int) {
+  fun detachHandlerFromHostDetector(handlerTag: Int, hostDetectorView: RNGestureHandlerDetectorView?) {
     handlers[handlerTag]?.let {
+      if (it.hostDetectorView != hostDetectorView) return
       detachHandlerInternal(it)
     }
   }

packages/react-native-gesture-handler/apple/RNGestureHandlerDetector.mm

@@ -53,11 +53,11 @@ - (void)willMoveToWindow:(RNGHWindow *)newWindow
 
     for (const auto handler : props.handlerTags) {
       NSNumber *handlerTag = [NSNumber numberWithInt:handler];
-      [handlerManager.registry detachHandlerWithTag:handlerTag];
+      [handlerManager.registry detachHandlerWithTag:handlerTag fromHostDetector:self];
     }
     for (const auto &child : _attachedVirtualHandlers) {
       for (id handlerTag : child.second) {
-        [handlerManager.registry detachHandlerWithTag:handlerTag];
+        [handlerManager.registry detachHandlerWithTag:handlerTag fromHostDetector:self];
       }
     }
     _attachedVirtualHandlers.clear();
@@ -232,7 +232,7 @@ - (void)attachHandlers:(const std::vector<int> &)handlerTags
   }
 
   for (const id tag : handlersToDetach) {
-    [handlerManager.registry detachHandlerWithTag:tag];
+    [handlerManager.registry detachHandlerWithTag:tag fromHostDetector:self];
     [attachedHandlers removeObject:tag];
     [_nativeHandlers removeObject:tag];
   }
@@ -276,7 +276,7 @@ - (void)updateVirtualChildren:(const std::vector<RNGestureHandlerDetectorVirtual
 
   for (const NSNumber *tag : virtualChildrenToDetach) {
     for (id handlerTag : _attachedVirtualHandlers[tag.intValue]) {
-      [handlerManager.registry detachHandlerWithTag:handlerTag];
+      [handlerManager.registry detachHandlerWithTag:handlerTag fromHostDetector:self];
     }
     _attachedVirtualHandlers.erase(tag.intValue);
   }
@@ -326,7 +326,7 @@ - (void)detachNativeGestureHandlers
   RNGestureHandlerManager *handlerManager = [RNGestureHandlerModule handlerManagerForModuleId:_moduleId];
 
   for (NSNumber *handlerTag in _nativeHandlers) {
-    [[handlerManager registry] detachHandlerWithTag:handlerTag];
+    [[handlerManager registry] detachHandlerWithTag:handlerTag fromHostDetector:self];
     [_attachedHandlers removeObject:handlerTag];
   }
 }

packages/react-native-gesture-handler/apple/RNGestureHandlerRegistry.h

@@ -17,6 +17,7 @@
               withActionType:(RNGestureHandlerActionType)actionType
             withHostDetector:(nullable RNGHUIView *)hostDetector;
 - (void)detachHandlerWithTag:(nonnull NSNumber *)handlerTag;
+- (void)detachHandlerWithTag:(nonnull NSNumber *)handlerTag fromHostDetector:(nonnull RNGHUIView *)hostDetectorView;
 - (void)dropHandlerWithTag:(nonnull NSNumber *)handlerTag;
 - (void)dropAllHandlers;
 

packages/react-native-gesture-handler/apple/RNGestureHandlerRegistry.m

@@ -48,9 +48,11 @@ - (void)attachHandlerWithTag:(NSNumber *)handlerTag
   }
 }
 
-- (void)detachHandlerWithTag:(NSNumber *)handlerTag
+- (void)detachHandlerWithTag:(NSNumber *)handlerTag fromHostDetector:(RNGHUIView *)hostDetectorView
 {
   RNGestureHandler *handler = _handlers[handlerTag];
+  if (handler.hostDetectorView != hostDetectorView)
+    return;
   [handler unbindFromView];
 }