Skip to content

Commit e593b2e

Browse files
authored
[Monorepo] Rename apps (#3519)
## Description This PR renames example apps an the ones generated by CLI are not valid (namely `name` field in `package.json` cannot be uppercased). It also: - Adds `yarn paper` script into `expo-example` app - Adds `yarn macos` into `macos-example` app - Removes `selfReferences` from `common-app` as without it `macos-example` doesn't start (expo seems to handle it better) ## Test plan Checked that example apps work
1 parent 555c18c commit e593b2e

206 files changed

Lines changed: 200 additions & 199 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.github/workflows/android-build-paper.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616

1717
runs-on: ubuntu-latest
1818
env:
19-
WORKING_DIRECTORY: apps/ExpoExample
19+
WORKING_DIRECTORY: apps/expo-example
2020
concurrency:
2121
group: android-paper-${{ github.ref }}
2222
cancel-in-progress: true

.github/workflows/android-build.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ on:
55
paths:
66
- .github/workflows/android-build.yml
77
- packages/react-native-gesture-handler/android/**
8-
- apps/BasicExample/android/**
8+
- apps/basic-example/android/**
99
push:
1010
branches:
1111
- main
@@ -18,7 +18,7 @@ jobs:
1818
runs-on: ubuntu-latest
1919
strategy:
2020
matrix:
21-
working-directory: [apps/BasicExample, apps/ExpoExample]
21+
working-directory: [apps/basic-example, apps/expo-example]
2222
concurrency:
2323
group: android-${{ matrix.working-directory }}-${{ github.ref }}
2424
cancel-in-progress: true

.github/workflows/check-archs-consistency.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ on:
88
- .github/workflows/check-archs-consistency.yml
99
- packages/react-native-gesture-handler/src/specs/**
1010
- packages/react-native-gesture-handler/package.json
11-
- apps/BasicExample/package.json
11+
- apps/basic-example/package.json
1212
push:
1313
branches:
1414
- main

.github/workflows/ios-build-paper.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717

1818
runs-on: macos-14
1919
env:
20-
WORKING_DIRECTORY: apps/ExpoExample
20+
WORKING_DIRECTORY: apps/expo-example
2121
concurrency:
2222
group: ios-paper-${{ matrix.working-directory }}-${{ github.ref }}
2323
cancel-in-progress: true

.github/workflows/ios-build.yml

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ on:
66
- .github/workflows/ios-build.yml
77
- packages/react-native-gesture-handler/RNGestureHandler.podspec
88
- packages/react-native-gesture-handler/apple/**
9-
- apps/BasicExample/ios/**
9+
- apps/basic-example/ios/**
1010
push:
1111
branches:
1212
- main
@@ -17,11 +17,9 @@ jobs:
1717
if: github.repository == 'software-mansion/react-native-gesture-handler'
1818

1919
runs-on: macos-14
20-
env:
21-
WORKING_DIRECTORY: apps/BasicExample
2220
strategy:
2321
matrix:
24-
working-directory: [apps/BasicExample, apps/ExpoExample]
22+
working-directory: [apps/basic-example, apps/expo-example]
2523
concurrency:
2624
group: ios-${{ matrix.working-directory }}-${{ github.ref }}
2725
cancel-in-progress: true
@@ -46,7 +44,7 @@ jobs:
4644
run: yarn install --immutable
4745

4846
- name: Install pods
49-
if: ${{ matrix.working-directory == 'apps/BasicExample' }}
47+
if: ${{ matrix.working-directory == 'apps/basic-example' }}
5048
working-directory: ${{ matrix.working-directory }}/ios
5149
run: bundle install && NO_FLIPPER=1 bundle exec pod install
5250

.github/workflows/macos-build.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ on:
66
- .github/workflows/macos-build.yml
77
- packages/react-native-gesture-handler/RNGestureHandler.podspec
88
- packages/react-native-gesture-handler/apple/**
9-
- apps/MacOSExample/macos/**
9+
- apps/macos-example/macos/**
1010
push:
1111
branches:
1212
- main
@@ -18,7 +18,7 @@ jobs:
1818

1919
runs-on: macos-15
2020
env:
21-
WORKING_DIRECTORY: apps/MacOSExample
21+
WORKING_DIRECTORY: apps/macos-example
2222
concurrency:
2323
group: macos-${{ github.ref }}
2424
cancel-in-progress: true

.github/workflows/static-example-apps-checks.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@ name: Test TypeScript and Lint
33
on:
44
pull_request:
55
paths:
6-
- apps/BasicExample/**'
7-
- apps/CommonApp/**
6+
- apps/basic-example/**'
7+
- apps/common-app/**
88
push:
99
branches:
1010
- main
@@ -17,7 +17,7 @@ jobs:
1717
runs-on: ubuntu-latest
1818
strategy:
1919
matrix:
20-
working-directory: [apps/BasicExample, apps/CommonApp]
20+
working-directory: [apps/basic-example, apps/common-app]
2121
concurrency:
2222
group: typescript-${{ matrix.working-directory }}-${{ github.ref }}
2323
cancel-in-progress: true

.lintstagedrc.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"{apps/BasicExample,packages/react-native-gesture-handler}/package.json": "node scripts/check-rn-versions.js",
2+
"{apps/basic-example,packages/react-native-gesture-handler}/package.json": "node scripts/check-rn-versions.js",
33
"**/*.{ts,tsx}": ["prettier --write", "eslint"],
44
"packages/react-native-gesture-handler/android/**/*.kt": [
55
"node scripts/check-android-dirs.js",

apps/ExpoExample/App.tsx

Lines changed: 0 additions & 3 deletions
This file was deleted.

0 commit comments

Comments
 (0)