Commit ee266bb
authored
Fix
## Description
`LegacyPressable` does not work as underlying button implementation had
changed. Because previous button is still accessible, I've changed
`LegacyPressable` to use it instead of new one, bringing back old
behavior.
On web it required some changes as buttons are exported as `export
default`, so simply changing non-web button and import in `Pressable`
caused crash on web.
I've also removed `forwardedRef` from web button and fixed button
example so it doesn't always indicate `onLongPress`.
## Test plan
Tested on expo-example, on examples with `Pressable` and `Buttons`
exampleLegacyPressable (#4016)1 parent 864cffe commit ee266bb
4 files changed
Lines changed: 13 additions & 7 deletions
File tree
- apps/common-app/src/new_api/components/buttons
- packages/react-native-gesture-handler/src/components
- Pressable
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
32 | | - | |
| 32 | + | |
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
70 | 70 | | |
71 | 71 | | |
72 | 72 | | |
73 | | - | |
| 73 | + | |
74 | 74 | | |
75 | 75 | | |
76 | 76 | | |
| |||
101 | 101 | | |
102 | 102 | | |
103 | 103 | | |
104 | | - | |
| 104 | + | |
105 | 105 | | |
106 | 106 | | |
107 | 107 | | |
| |||
Lines changed: 9 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
| 2 | + | |
3 | 3 | | |
4 | | - | |
5 | | - | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
6 | 10 | | |
| 11 | + | |
| 12 | + | |
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
22 | | - | |
| 22 | + | |
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
| |||
0 commit comments