Skip to content

[3.0.0 - beta.1] Failing iOS Production Build (Fix Provided) #3966

@ChristopherGabba

Description

@ChristopherGabba

Description

There are three lines that need semi-colons that stop the build from completing in production.

Steps to reproduce

Here is the patch file that fixes the issue:

diff --git a/node_modules/react-native-gesture-handler/apple/RNGestureHandlerDetector.mm b/node_modules/react-native-gesture-handler/apple/RNGestureHandlerDetector.mm
index 3b5034b..e67ddbf 100644
--- a/node_modules/react-native-gesture-handler/apple/RNGestureHandlerDetector.mm
+++ b/node_modules/react-native-gesture-handler/apple/RNGestureHandlerDetector.mm
@@ -47,7 +47,7 @@
 {
   if (newWindow == nil) {
     RNGestureHandlerManager *handlerManager = [RNGestureHandlerModule handlerManagerForModuleId:_moduleId];
-    react_native_assert(handlerManager != nullptr && "Tried to access a non-existent handler manager")
+    react_native_assert(handlerManager != nullptr && "Tried to access a non-existent handler manager");
         const auto &props = *std::static_pointer_cast<const RNGestureHandlerDetectorProps>(_props);
 
     for (const auto handler : props.handlerTags) {
@@ -190,7 +190,7 @@
       attachedHandlers:(NSMutableSet *)attachedHandlers
 {
   RNGestureHandlerManager *handlerManager = [RNGestureHandlerModule handlerManagerForModuleId:_moduleId];
-  react_native_assert(handlerManager != nullptr && "Tried to access a non-existent handler manager")
+  react_native_assert(handlerManager != nullptr && "Tried to access a non-existent handler manager");
 
       NSMutableSet *handlersToDetach = [attachedHandlers mutableCopy];
 
@@ -262,7 +262,7 @@
 - (void)updateVirtualChildren:(const std::vector<RNGestureHandlerDetectorVirtualChildrenStruct> &)virtualChildren
 {
   RNGestureHandlerManager *handlerManager = [RNGestureHandlerModule handlerManagerForModuleId:_moduleId];
-  react_native_assert(handlerManager != nullptr && "Tried to access a non-existent handler manager")
+  react_native_assert(handlerManager != nullptr && "Tried to access a non-existent handler manager");
 
       NSMutableSet *virtualChildrenToDetach = [NSMutableSet set];
   for (const auto &child : _attachedVirtualHandlers) {

A link to a Gist, an Expo Snack or a link to a repository based on this template that reproduces the bug.

N/A

Gesture Handler version

3.0.0-beta1

React Native version

0.83

Platforms

iOS

JavaScript runtime

None

Workflow

None

Architecture

None

Build type

None

Device

None

Device model

No response

Acknowledgements

Yes

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions