-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Update how Gesture Handler exposes setGestureState to the Reanimated UI runtime
#3207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
b8f9632
Bump Reanimated
j-piasecki 583b499
Update ios
j-piasecki 4a506bf
Update android
j-piasecki fb5543a
Use Reanimated 4 beta
j-piasecki 17c6ce1
Renames:
j-piasecki 96be8a7
Decorate UI runtime lazily
j-piasecki fde59ee
Use non-deprecated method
j-piasecki 126943a
Rename to `_setGestureStateSync`
j-piasecki 90877be
Extract runtime decoration to shared code
j-piasecki 366dcdc
Prefix with underscore
j-piasecki e40e4e0
Handle calling setGestureState from other threads
j-piasecki 9fe3f60
Expose `_setGestureStateAsync` to JS runtime
j-piasecki 105e6f8
Make state manager work also on JS
j-piasecki d10ddec
Add cpp format script
j-piasecki 38a0c20
Format c++
j-piasecki 5bd5f46
Don't format build folders
j-piasecki 53a79f0
Fix header
j-piasecki d835f7a
Remove some gates
j-piasecki d64938a
Bump reanimated to beta 5
j-piasecki c1c00b4
Don't try to decorate UI runtime without Reanimated and throw on failure
j-piasecki a5ea8e4
Android changes from review
j-piasecki 4306217
iOS changes after review
j-piasecki b1653e2
Changes to shared
j-piasecki 71f3699
Throw error when no methods available
j-piasecki c6a87ac
Release `javaPart` on module invalidate
j-piasecki fdaccf5
Mark `tagMessage` as worklet
j-piasecki 0454c96
Increase memory for basic-example build
j-piasecki 801acd8
Continuously check whether ui runtime was decorated
j-piasecki 2b43704
Make `createGestureHandler` synchronous and run on the JS thread
j-piasecki d4606a0
Add comment about createGestureHandler returning a bool
j-piasecki d1af5ad
Remove todo
j-piasecki 843b069
Make comment start uppercase
j-piasecki 77ac470
Rename method
j-piasecki 4d51da1
Rename fields
j-piasecki da123f7
Unify format apple and format cpp scripts
j-piasecki 91a3bf3
Remove log
j-piasecki 2e3215e
Rename count -> argumentCount
j-piasecki File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| module.exports = { | ||
| presets: ['module:@react-native/babel-preset'], | ||
| plugins: ['react-native-worklets/plugin'], | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.