You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@latekvo/fix-fabric-border-colors-etcsoftware-mansion/react-native-gesture-handler:@latekvo/fix-fabric-border-colors-etcCopy head branch name to clipboard
@latekvo/fix-fabric-border-colors-etcsoftware-mansion/react-native-gesture-handler:@latekvo/fix-fabric-border-colors-etcCopy head branch name to clipboard
This PR adds missing prop styles fields to the RNGestureHandlerButton delegate.
Since a lot of new logic would be required to support these new props, I decided to also rewrite ButtonViewGroup to use ReactViewGroup instead of ViewGroup, as our current implementation seemed to already share most of it's drawing-related code with the ReactViewGroup.
The only logic missing from ReactViewGroup was the ripple logic, the foreground logic, and the touch handling logic, so i kept those in place. Remaining redundant code was removed.
I think an approach with two views, where the outer one applies styling and the inner one is the actual button, would be safer and work on both platforms (iOS suffers from the same problem). We tried that in the past and failed, but now we could build it relying on display: contents not to break any layout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds missing prop styles fields to the RNGestureHandlerButton delegate.
Since a lot of new logic would be required to support these new props, I decided to also rewrite
ButtonViewGroupto useReactViewGroupinstead ofViewGroup, as our current implementation seemed to already share most of it's drawing-related code with theReactViewGroup.The only logic missing from
ReactViewGroupwas theripplelogic, the foreground logic, and the touch handling logic, so i kept those in place. Remaining redundant code was removed.Fixes #3304
Test plan
Collapsed example