Make base GestureHandler on Android non generic#3491
Merged
j-piasecki merged 9 commits intomainfrom May 27, 2025
Merged
Conversation
56ec5f6 to
d0083b9
Compare
d0083b9 to
9307f2d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Depends on #3489
On Android,
GestureHandlerwas a generic class specialized by the concrete type of the handler. The only place it was used wasapplySelfmethod, which allowed for inherited methods to return the concrete handler:...but we don't use this pattern anywhere. It made much more sense in Java, than it does in Kotlin, where we can simply use
apply,let, etc. when there's a need to do multiple operations on the same object. Now, it simply makes the logic dealing with gesture handlers more complicated as it also needs to keep track of the generic type, which in most cases is*so it doesn't give us more type safety.This PR makes it so that the base
GestureHandlerclass is no longer generic, which should make life easier when dealing with non-concrete gesture handlers in the future.Test plan
Build example apps