Skip to content

[Monorepo] Cleanup#3515

Merged
m-bert merged 110 commits into@mbert/monorepofrom
@mbert/monorepo-cleanup
May 15, 2025
Merged

[Monorepo] Cleanup#3515
m-bert merged 110 commits into@mbert/monorepofrom
@mbert/monorepo-cleanup

Conversation

@m-bert
Copy link
Copy Markdown
Collaborator

@m-bert m-bert commented May 12, 2025

Description

This PR consists of changes that aim to clean repository after moving into monorepo, namely:

  • Unify quotations in github workflows
  • Remove unnecessary config files
  • Remove unnecessary dependencies
  • Changes scripts:
    • Android format script now drops argument instead of only working at one file. I wanted to make it work only on staged files, however it takes a lot of time since gradle has to start over and over. Unfortunately, multiple files for spotlessIdeHook are not in the roadmap.
    • Added apple format script which formats only staged files (or whole apple codebase if run without argument)
    • Added script for checking whether staged android files are included in package.json 😅
  • Make sure that lint-staged operates only on staged files (if possible)
  • Remove e2e app
  • Add yarn clean script

Test plan

Check that CIs pass and example apps work as expected

@m-bert m-bert changed the base branch from main to @mbert/monorepo-prepare-paper May 12, 2025 14:27
@m-bert m-bert mentioned this pull request May 12, 2025
23 tasks
Base automatically changed from @mbert/monorepo-prepare-paper to @mbert/monorepo May 13, 2025 15:22
@m-bert m-bert marked this pull request as ready for review May 14, 2025 09:02
Comment thread .eslintrc.json Outdated
Comment thread packages/react-native-gesture-handler/package.json Outdated
Comment thread scripts/format-apple.js Outdated
Comment thread scripts/check-android-dirs.js
@m-bert m-bert requested a review from j-piasecki May 15, 2025 10:50
@m-bert m-bert merged commit fda1818 into @mbert/monorepo May 15, 2025
10 checks passed
@m-bert m-bert deleted the @mbert/monorepo-cleanup branch May 15, 2025 12:30
m-bert added a commit that referenced this pull request May 23, 2025
## Description

This is base PR that migrates our repository into monorepo structure. It creates following structure:

- `/apps` - here we will put our example apps.
- `/packages` - main directory for Gesture Handler package, along with documentation.
- `/scripts` - scripts that are used by _**GestureHandler**_ (for example formatting scripts)

## Steps

<details>
<summary>Here is the list of PRs that fix issues caused by changing structure of the repository:</summary>

1. #3487
2. #3490
3. #3494
4. #3495
5. #3496
6. #3497
7. #3503
8. #3506
9. #3507
10. #3510
11. #3515
12. #3518
13. #3519
14. #3524
15. #3525
16. #3526
18. #3528

</details>

Note that most of them depends on previous ones, so **_they had to be merged in given order_** (at least up to no. 9).

## Test plan

<details>
<summary>Following subjects were tested in order to make sure that everything works after migration:</summary>

### Example apps

- [x] basic-example
  - [x] Android
  - [x] iOS
- [x] expo-example (fabric)
  - [x] Android
  - [x] iOS
  - [x] web (in that case architecture doesn't matter)
- [x] expo-example (paper)
  - [x] Android
  - [x] iOS
- [x] macos-example

### Scripts

- [x] check-android-dirs
- [x] check-rn-versions
- [x] format-android
- [x] format-apple
- [x] codegen-check-consistency
- [x] codegen-sync-archs
- [x] clangd

### Linters

- [x] prettier
- [x] eslint
- [x] lint-staged

### docs

- [x] check documentation

### Build from generated package

- [x] New app builds correctly

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants