[Monorepo] Rename apps#3519
Merged
Merged
Conversation
j-piasecki
approved these changes
May 19, 2025
Comment on lines
+310
to
+316
| void AsyncStorage.multiGet([OPEN_LAST_EXAMPLE_KEY, LAST_EXAMPLE_KEY]).then( | ||
| ([openLastExample, lastExample]) => { | ||
| if (openLastExample[1] === 'true' && lastExample[1]) { | ||
| navigate(navigation, lastExample[1]); | ||
| } | ||
|
|
||
| return; |
Collaborator
Author
There was a problem hiding this comment.
Yep, this is because eslint for some reason started yelling at me and I wanted to avoid adding another ignores/warns 😅
23 tasks
m-bert
added a commit
that referenced
this pull request
May 23, 2025
## Description This is base PR that migrates our repository into monorepo structure. It creates following structure: - `/apps` - here we will put our example apps. - `/packages` - main directory for Gesture Handler package, along with documentation. - `/scripts` - scripts that are used by _**GestureHandler**_ (for example formatting scripts) ## Steps <details> <summary>Here is the list of PRs that fix issues caused by changing structure of the repository:</summary> 1. #3487 2. #3490 3. #3494 4. #3495 5. #3496 6. #3497 7. #3503 8. #3506 9. #3507 10. #3510 11. #3515 12. #3518 13. #3519 14. #3524 15. #3525 16. #3526 18. #3528 </details> Note that most of them depends on previous ones, so **_they had to be merged in given order_** (at least up to no. 9). ## Test plan <details> <summary>Following subjects were tested in order to make sure that everything works after migration:</summary> ### Example apps - [x] basic-example - [x] Android - [x] iOS - [x] expo-example (fabric) - [x] Android - [x] iOS - [x] web (in that case architecture doesn't matter) - [x] expo-example (paper) - [x] Android - [x] iOS - [x] macos-example ### Scripts - [x] check-android-dirs - [x] check-rn-versions - [x] format-android - [x] format-apple - [x] codegen-check-consistency - [x] codegen-sync-archs - [x] clangd ### Linters - [x] prettier - [x] eslint - [x] lint-staged ### docs - [x] check documentation ### Build from generated package - [x] New app builds correctly </details>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR renames example apps an the ones generated by CLI are not valid (namely
namefield inpackage.jsoncannot be uppercased).It also:
yarn paperscript intoexpo-exampleappyarn macosintomacos-exampleappselfReferencesfromcommon-appas without itmacos-exampledoesn't start (expo seems to handle it better)Test plan
Checked that example apps work