Remove ViewManagerWithGeneratedInterface from old arch interfaces#3584
Remove ViewManagerWithGeneratedInterface from old arch interfaces#3584geraintwhite wants to merge 1 commit intosoftware-mansion:mainfrom
Conversation
Fix Confirmed - ViewManagerWithGeneratedInterface Interface IssueI encountered this exact same issue with React Native 0.74.3 and Root CauseThe issue occurs because Specifically, these two files have problematic interface definitions:
SolutionThe fix is to remove the Manual Fix:
Permanent Solution with patch-package: # After making the manual changes above
npm install patch-package --save-dev
npx patch-package react-native-gesture-handler
# Add to package.json scripts
"postinstall": "patch-package"Why This WorksThe Tested with:
Build now completes successfully with no functional impact on gesture handling. Commenting here because #3564 is closed |
|
Hi! Is there a situation where compilation on android crashes without this fix while using compatible versions of both, Also remember, that starting from 0.82, it is not possible to use old architecture. @shashank-bhatotia For Gesture Handler 2.27.0 you should use React Native 0.78 or higher. Unfortunately 0.74 is not supported. |
|
@m-bert — following up on your "valid reproduction needed" question with a clean repro on a configuration that's within Repro: RN 0.77.3 + Why this is real, not just a "use a newer RN" answer:
So the patch in this PR isn't a workaround — it's the upstream-equivalent regeneration of stale pre-shipped paper sources, matching exactly what RN's current codegen would emit if Real-world impact: anyone mid-RN-0.77-upgrade who can't yet flip to New Architecture (e.g. blocked by other native modules whose new-arch readiness isn't ready, or by deadline/scope on a release branch) hits this. Bumping RN to 0.78 to dodge the issue isn't always available as an option on a release timeline. The same root cause is also reported against Would you reconsider merging — or shipping a 2.27.3 / 2.32.x patch release with this regeneration applied? Happy to add a CI repro project demonstrating the failure, or to tighten the diff (the original PR is already minimal — just two interface files, four lines removed). cc @geraintwhite — same change you proposed; reviving with the additional evidence. |
As I stated earlier, for 2.27.2 you should use React Native 0.78 or higher. This one should work as we test both platforms build before release.
Unfortunately not, 2.27 is quite old and we no longer support it. Also 2.31.1 was released with React Native 0.85, so we would target changes at most to 0.82, not 0.77. |
|
Got it, thanks for the clarification. We'll carry the patch locally until we move to RN 0.78+ in a follow-up upgrade. Appreciate the time. |
|
Thank you for your understanding! Let me know if you need any further assistance. |
Description
Fixes #3564
Remove unneeded
ViewManagerWithGeneratedInterfaceextend from old arch to preserve backwards compatibility with RN 0.77Test plan
App builds and runs on RN 0.77 with old arch with this patch.