Implement base for a native detector component#3599
Merged
Conversation
WoLewicki
reviewed
Jul 4, 2025
Update ios Renames: - `setGestureState` -> `setGestureState_DEPRECATED` (JSI injected name stays the same for compatibility) - `_setGestureStateNew` -> `_setGestureStateModern` Decorate UI runtime lazily Extract runtime decoration to shared code Prefix with underscore Expose `_setGestureStateAsync` to JS runtime Format c++ Fix header Don't try to decorate UI runtime without Reanimated and throw on failure iOS changes after review Changes to shared Continuously check whether ui runtime was decorated Make `createGestureHandler` synchronous and run on the JS thread Bump Reanimated Use Reanimated 4 beta Extract runtime decoration to shared code Bump reanimated to beta 5
j-piasecki
force-pushed
the
@jpiasecki/native-detector
branch
from
e3164c4 to
7e73369
Compare
m-bert
reviewed
Jul 7, 2025
m-bert
reviewed
Jul 11, 2025
| private var animatedEvents: Boolean = false | ||
|
|
||
| fun setHandlerTags(handlerTags: ReadableArray?) { | ||
| val newHandlers = handlerTags?.toArrayList()?.map { (it as Double).toInt() } ?: emptyList() |
Collaborator
There was a problem hiding this comment.
I assume that we cannot make it Int in other way?
(it as Double).toInt()
Member
Author
There was a problem hiding this comment.
We could cast the entire ArrayList, but I don't think it's much better.
Collaborator
There was a problem hiding this comment.
Yeah, I don't think it changes that much 😅
m-bert
approved these changes
Jul 11, 2025
Collaborator
m-bert
left a comment
m-bert
left a comment
There was a problem hiding this comment.
Let's merge this bad boy 🚀 
This PR got pretty big and given that it targets next I think we can merge it and then continue with development 😅
WoLewicki
reviewed
Jul 11, 2025
| ) | ||
|
|
||
| target_include_directories(react_codegen_rngesturehandler_codegen PUBLIC ../shared/shadowNodes) | ||
| target_include_directories(react_codegen_rngesturehandler_codegen PUBLIC ./build/generated/source/codegen/jni) |
Member
There was a problem hiding this comment.
Why do you link codegen files explicitly?
Member
There was a problem hiding this comment.
Oh okay, you use them in your shared folder, got it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements a native
RNGestureHandlerDetectorcomponent based ondisplay: contents:TODO:
NativeViewGestureHandler, which should be attached to the child (I think)Test plan
Updated basic example