[android] fix scroll actions interpreted as touch#3850
Merged
Conversation
kosmydel
force-pushed
the
@kosmydel/fix-scroll
branch
from
f301097 to
71dbcd7
Compare
kosmydel
force-pushed
the
@kosmydel/fix-scroll
branch
from
71dbcd7 to
e7fa78a
Compare
m-bert
pushed a commit
that referenced
this pull request
Dec 16, 2025
The scroll action on the Meta Quest Joystick lead to triggering the Pan gesture when it shouldn't. This PR filters out this `ACTION_SCROLL` by applying whitelist in the `dispatchGenericMotionEvent` for the hover events only.
m-bert
added a commit
that referenced
this pull request
Jun 16, 2026
## Description #3850 restricted dispatching of generic motion events to only hover events. This caused a regression in which mouse events stopped being dispatched to handlers. This PR allows mouse events to be dispatched to handlers and adds check for mouse button press in Long Press so it can activate timeout. It also removes check for obsolete SDK version and inverts logic of skipping events - `shouldActivateWithMouse` wasn't very descriptive (especially in `onHandle`), so I renamed it to `shouldSkipEvent` instead. Fixes #3889 ## Test plan Tested on mouse buttons and Pressable examples
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The scroll action on the Meta Quest Joystick lead to triggering the Pan gesture when it shouldn't. This PR filters out this
ACTION_SCROLLby applying whitelist in thedispatchGenericMotionEventfor the hover events only.