[General] Cleanup duplicated callbacks#3885
Merged
j-piasecki merged 4 commits intonextfrom Jan 23, 2026
Merged
Conversation
Collaborator
|
Could you check this example? Example codeimport { StyleSheet, View } from 'react-native';
import {
Gesture,
GestureDetector,
GestureHandlerRootView,
useTapGesture,
} from 'react-native-gesture-handler';
const uiManager = global?.nativeFabricUIManager ? 'Fabric' : 'Paper';
console.log(`Using ${uiManager}`);
export default function App() {
const g = useTapGesture({
onDeactivate: () => {
'worklet';
console.log('Tap!');
},
});
return (
<GestureHandlerRootView style={styles.container}>
<GestureDetector gesture={g}>
<View style={styles.ball} />
</GestureDetector>
</GestureHandlerRootView>
);
}
const styles = StyleSheet.create({
container: {
flex: 1,
alignItems: 'center',
justifyContent: 'space-around',
},
ball: {
width: 300,
height: 300,
borderRadius: 150,
backgroundColor: 'crimson',
},
});It seems to work on both |
fcd7059 to
aa55e76
Compare
Member
Author
|
Seems to be working (after rebasing on next): Screen.Recording.2026-01-22.at.08.26.36.mov |
m-bert
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After the optimization PRs, the event handlers for js/ui thread were collapsed to a single function, but throughout the code, those are still being passed like before those changes - as three separate functions. Those are the same exact functions but under different names. This PR changes that, so that only one function is passed. Ultimately, this function still ends up in three different events, but the split now happens at the leafs instead of the root.
Test plan
Gestures should still work