[General] Move the end flag to the event passed to onDeactivate and onFinalize#3887
Open
j-piasecki wants to merge 1 commit intonextfrom
Open
[General] Move the end flag to the event passed to onDeactivate and onFinalize#3887j-piasecki wants to merge 1 commit intonextfrom
onDeactivate and onFinalize#3887j-piasecki wants to merge 1 commit intonextfrom
Conversation
m-bert
reviewed
Apr 9, 2026
Contributor
m-bert
left a comment
m-bert
left a comment
There was a problem hiding this comment.
Been a while, sorry for that!
I like the idea, though I think we stray from the "all callbacks use the same event". But on the other hand, we already did that so it should be fine.
Anyway, if you'd still like this change, can you merge main? 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Up to this point, the API mirrored V2, where
successwas being passed as an additional parameter to the end callbacks.This PR changes it, so the flag is being passed as part of the event to the callbacks. I also think that the approach to working with gestures is to assume that they will succeed, so I changed the flag to
canceled.This also seems to be the easiest one to explain in the docs - "the gesture was canceled due to failure to meet activation criteria, the activation of another gesture, by the OS".
Test plan
Verify that
calceledexists in events passed toonDeactivateandonFinalize.