Skip to content

Fix intercepting detector props#3952

Merged
j-piasecki merged 6 commits intonextfrom
@akwasniewski/fix-intercepting-detector-props
Feb 5, 2026
Merged

Fix intercepting detector props#3952
j-piasecki merged 6 commits intonextfrom
@akwasniewski/fix-intercepting-detector-props

Conversation

@akwasniewski
Copy link
Copy Markdown
Contributor

Description

InterceptingDetectorProps was missing some types from GestureDetectorProps this PR makes both types extend CommonGestureDetectorProps

Test plan

yarn ts-check

@akwasniewski akwasniewski requested a review from m-bert February 4, 2026 14:23
Comment thread packages/react-native-gesture-handler/src/v3/detectors/common.ts
@m-bert
Copy link
Copy Markdown
Collaborator

m-bert commented Feb 5, 2026

Also, shouldn't these props be added to the VirtualGestureDetector as well?

@j-piasecki j-piasecki merged commit 0f13426 into next Feb 5, 2026
3 checks passed
@j-piasecki j-piasecki deleted the @akwasniewski/fix-intercepting-detector-props branch February 5, 2026 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants