[General] Only overwrite ref if the dropped handler didn't change#3984
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a race where an outdated useEffect cleanup could clear currentGestureRef after a newer handler updated it, leading to erroneous re-creation and potential crashes during rapid updates (e.g., React Refresh / fast updates).
Changes:
- Guard
currentGestureRefcleanup so it only resets the ref when the ref still points at the handler being dropped.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tomekzaw
approved these changes
Feb 18, 2026
Member
tomekzaw
left a comment
There was a problem hiding this comment.
I've tried this PR in my app and it fixes the bug. Thanks!
akwasniewski
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It's possible that when a gesture is updated, the new values in the ref will be overwritten after being updated, due to the cleanup not checking what it's deleting.
It was possible to get this scenario:
where the last update would crash due to the ref being cleared by the cleanup of
TapGestureHandler 1AFTER being updated byTapGestureHandler 2.Test plan
File 1:
File2:
Comment out
COMMENT_THIS_FIRST, save, then comment outCOMMENT_THIS_SECONDand save.