[docs] Make platforms optional parameter#3992
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the HeaderWithBadges component to make the platforms prop optional, enabling it to display only a version badge when needed. It also removes the deprecated HeaderWithBadge component that was previously replaced by HeaderWithBadges.
Changes:
- Made
platformsprop optional inHeaderWithBadgesPropstype definition - Removed entire
HeaderWithBadgecomponent file (91 lines) that is no longer in use
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/docs-gesture-handler/src/components/HeaderWithBadges/index.tsx | Made platforms prop optional to support version-only badge display |
| packages/docs-gesture-handler/src/components/HeaderWithBadge/index.tsx | Removed deprecated component that was replaced by HeaderWithBadges |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
m-bert
changed the title
platforms optional parametrplatforms optional parameter
j-piasecki
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR does 2 things:
HeaderWithBadgecomponent, which was replaced byHeaderWithBadgesplatformsprop optional, so it is possible to add only version badge.Note
HeaderWithBadgesalready treatsplatformsas optional with optional chaining.Test plan
Read docs 🤓