Revert "Export new createNativeWrapper (#3971)"#4001
Conversation
This reverts commit bdf353d.
| export { RotationGestureHandler } from './handlers/RotationGestureHandler'; | ||
| export { FlingGestureHandler } from './handlers/FlingGestureHandler'; | ||
| export { default as legacy_createNativeWrapper } from './handlers/createNativeWrapper'; | ||
| export { default as createNativeWrapper } from './handlers/createNativeWrapper'; |
There was a problem hiding this comment.
Even though we're still in beta, I can see the reason why we would want to keep legacy prefix here. WDYT @j-piasecki @akwasniewski?
There was a problem hiding this comment.
Fine by me, we should mention that in the migration guide and llm skill
There was a problem hiding this comment.
Do you see any reason agains deprecating it?
There was a problem hiding this comment.
There was a problem hiding this comment.
Pull request overview
This PR reverts the export of a new createNativeWrapper function from the v3 API (commit bdf353d). The decision was made to avoid confusion about when to use the new wrapper versus the legacy one. The revert restores the original naming convention where createNativeWrapper refers to the legacy implementation.
Changes:
- Removed export of new
createNativeWrapperfrom v3 index - Reverted
legacy_createNativeWrapperback tocreateNativeWrapperin main index - Removed documentation page for the new
createNativeWrapper - Removed migration guide sections about the new wrapper
- Cleaned up empty lines in migration documentation for consistency
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
packages/react-native-gesture-handler/src/v3/index.ts |
Removed export of new createNativeWrapper from v3 API |
packages/react-native-gesture-handler/src/index.ts |
Reverted legacy_createNativeWrapper back to createNativeWrapper |
packages/docs-gesture-handler/docs/components/create-native-wrapper.mdx |
Completely removed documentation page for new wrapper |
packages/docs-gesture-handler/docs/guides/upgrading-to-3.mdx |
Removed migration section about new wrapper and adjusted import statement placement |
skills/gesture-handler-3-migration/SKILL.md |
Removed guidance about new wrapper and cleaned up formatting |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This reverts commit bdf353d.
Description
We decided that it will be better not to export new
createNativeWrapperas it might be confusing when to use it.Test plan
Try to import
createNativeWrapperRead docs 🤓