Skip to content

[General] Replace enabled with disabled prop on Clickable #4057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
j-piasecki wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −2
Open

[General] Replace enabled with disabled prop on Clickable #4057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/common-app/src/new_api/components/clickable_stress/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ export default function ClickableStress() {
activeUnderlayOpacity={0.105}
style={[styles.startButton, isRunning && styles.startButtonBusy]}
onPress={start}
enabled={!isRunning}>
disabled={isRunning}>
<Text style={styles.startButtonText}>
{isRunning ? `Running ${currentRun}/${N}...` : 'Start test'}
</Text>
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native-gesture-handler/src/v3/components/Clickable/Clickable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ export const Clickable = (props: ClickableProps) => {
onPressOut,
onActiveStateChange,
children,
disabled = false,
ref,
...rest
} = props;
Expand Down Expand Up @@ -115,6 +116,7 @@ export const Clickable = (props: ClickableProps) => {
{...rest}
{...rippleProps}
ref={ref ?? null}
enabled={!disabled}
onBegin={onBegin}
onActivate={onActivate}
onDeactivate={onDeactivate}
Expand Down
7 changes: 6 additions & 1 deletion packages/react-native-gesture-handler/src/v3/components/Clickable/ClickableProps.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type PressableAndroidRippleConfig = {

type RippleProps = 'rippleColor' | 'rippleRadius' | 'borderless' | 'foreground';

export type ClickableProps = Omit<ButtonProps, RippleProps> &
export type ClickableProps = Omit<ButtonProps, RippleProps | 'enabled'> &
Omit<BaseButtonProps, keyof RawButtonProps> & {
Comment on lines +18 to 19
Copy link

Copilot AI Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change removes enabled from the public ClickableProps type. If the goal is to rename rather than hard-remove, consider keeping enabled?: boolean as a deprecated alias for at least one release (with disabled taking precedence) to provide a smoother migration path for TypeScript users and to align with any runtime backward-compat handling.

Copilot uses AI. Check for mistakes.
/**
* Configuration for the ripple effect on Android.
Expand All @@ -31,4 +31,9 @@ export type ClickableProps = Omit<ButtonProps, RippleProps> &
* Called when pointer is released from the component.
*/
onPressOut?: ((event: CallbackEventType) => void) | undefined;

/**
* Whether the component should ignore touches. By default set to false.
*/
disabled?: boolean | undefined;
};
Loading