[docs] Fix remaining Copilot review issues: capitalization and grammar#4058
Closed
Copilot wants to merge 2 commits into@mbert/docs-grammarfrom
Closed
[docs] Fix remaining Copilot review issues: capitalization and grammar#4058Copilot wants to merge 2 commits into@mbert/docs-grammarfrom
Copilot wants to merge 2 commits into@mbert/docs-grammarfrom
Conversation
## Description Native platforms delay touches when the button is inside a ScrollView. This may cause situations where press-out is triggered immediately after press-in, effectively running with no animation. This PR: - changes the easing on web to better align with native platforms - changes `animationDuration` to `pressAndHoldAnimationDuration` - adds `tapAnimationDuration` `pressAndHoldAnimationDuration` defaults to `tapAnimationDuration` when unspecified; `tapAnimationDuration` defaults to 100ms. Press out handler now has three branches: 1. pressDuration >= `pressAndHoldAnimationDuration` -> press out animation is started immediately with the duration of `pressAndHoldAnimationDuration` 2. pressDuration * 2 in [`tapAnimationDuration`, `pressAndHoldAnimationDuration`] (*2 so there's at least half of `tapAnimationDuration` for the remaining animation) -> press out animation is started immediately with the duration of the press so far 3. pressDuration < `tapAnimationDuration / 2` -> pressIn animation is played fully in the remaining time in `tapAnimationDuration`, and pressOut is scheduled after with the duration of `tapAnimationDuration` ## Test plan Updated the button underlay example
…fixes Agent-Logs-Url: https://github.com/software-mansion/react-native-gesture-handler/sessions/de39b400-f365-4486-ab65-f619debecb58 Co-authored-by: m-bert <63123542+m-bert@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
m-bert
April 7, 2026 07:34
View session
m-bert
approved these changes
Apr 7, 2026
Contributor
|
Agent targeted wrong branch. Cherry-picked into #4056 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
copilot/fix-last-copilot-review-problemsonto@mbert/docs-grammar, resolving all merge conflicts