Skip to content

[iOS] Fix buttons crash when unmounting children #4065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
m-bert merged 3 commits into from
Apr 9, 2026
+5 −2
Merged

[iOS] Fix buttons crash when unmounting children #4065

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
075f8e4
Do not pass index to unmount
m-bert Apr 8, 2026
886be0a
Guard before removing
m-bert Apr 9, 2026
000c9aa
Merge branch 'main' into @mbert/fix-buttons-unmount-crash
m-bert Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/react-native-gesture-handler/apple/RNGestureHandlerButtonComponentView.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,12 @@ - (void)mountChildComponentView:(RNGHUIView<RCTComponentViewProtocol> *)childCom
[_buttonView mountChildComponentView:childComponentView index:index];
}

- (void)unmountChildComponentView:(RNGHUIView<RCTComponentViewProtocol> *)childComponentView index:(NSInteger)index
- (void)unmountChildComponentView:(RNGHUIView<RCTComponentViewProtocol> *)childComponentView
index:(NSInteger)__unused index
{
[_buttonView unmountChildComponentView:childComponentView index:index];
if (childComponentView.superview == _buttonView) {
[childComponentView removeFromSuperview];
}
}

- (LayoutMetrics)buildWrapperMetrics:(const LayoutMetrics &)metrics
Expand Down
Loading