Skip to content

Fix Touchables typescript errors #4067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
m-bert merged 2 commits into from
Apr 9, 2026
Merged

Fix Touchables typescript errors #4067

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c23cc18
Touchable ts errors
m-bert Apr 9, 2026
9b343eb
Remove todo
m-bert Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 9 additions & 11 deletions packages/react-native-gesture-handler/src/components/touchables/GenericTouchable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,7 @@ interface InternalProps {
onStateChange?: (oldState: TouchableState, newState: TouchableState) => void;
}

// TODO: maybe can be better
// TODO: all clearTimeout have ! added, maybe they shouldn't ?
type Timeout = ReturnType<typeof setTimeout> | null | undefined;
type Timeout = ReturnType<typeof setTimeout> | undefined;

/**
* GenericTouchable is not intented to be used as it is.
Expand Down Expand Up @@ -70,7 +68,7 @@ export default class GenericTouchable extends Component<
if (this.props.delayPressIn) {
this.pressInTimeout = setTimeout(() => {
this.moveToState(TOUCHABLE_STATE.BEGAN);
this.pressInTimeout = null;
this.pressInTimeout = undefined;
}, this.props.delayPressIn);
} else {
this.moveToState(TOUCHABLE_STATE.BEGAN);
Expand All @@ -89,7 +87,7 @@ export default class GenericTouchable extends Component<
this.pressOutTimeout ||
setTimeout(() => {
this.moveToState(TOUCHABLE_STATE.MOVED_OUTSIDE);
this.pressOutTimeout = null;
this.pressOutTimeout = undefined;
}, this.props.delayPressOut);
} else {
this.moveToState(TOUCHABLE_STATE.MOVED_OUTSIDE);
Expand All @@ -105,7 +103,7 @@ export default class GenericTouchable extends Component<
this.moveToState(TOUCHABLE_STATE.BEGAN);
}
this.moveToState(TOUCHABLE_STATE.UNDETERMINED);
this.pressOutTimeout = null;
this.pressOutTimeout = undefined;
}, this.props.delayPressOut);
} else {
if (this.STATE === TOUCHABLE_STATE.UNDETERMINED) {
Expand All @@ -125,9 +123,9 @@ export default class GenericTouchable extends Component<
clearTimeout(this.pressInTimeout);
clearTimeout(this.pressOutTimeout);
clearTimeout(this.longPressTimeout);
this.pressOutTimeout = null;
this.longPressTimeout = null;
this.pressInTimeout = null;
this.pressOutTimeout = undefined;
this.longPressTimeout = undefined;
this.pressInTimeout = undefined;
}

// All states' transitions are defined here.
Expand Down Expand Up @@ -189,7 +187,7 @@ export default class GenericTouchable extends Component<
const shouldCallOnPress =
!this.longPressDetected &&
this.STATE !== TOUCHABLE_STATE.MOVED_OUTSIDE &&
this.pressOutTimeout === null;
this.pressOutTimeout === undefined;
this.handleGoToUndetermined();
if (shouldCallOnPress) {
// Calls only inside component whether no long press was called previously
Expand Down Expand Up @@ -219,7 +217,7 @@ export default class GenericTouchable extends Component<
onMoveOut() {
// Long press should no longer be detected
clearTimeout(this.longPressTimeout);
this.longPressTimeout = null;
this.longPressTimeout = undefined;
if (this.STATE === TOUCHABLE_STATE.BEGAN) {
this.handleMoveOutside();
}
Expand Down
Loading