Skip to content

[eslint] Consistent import rules#4087

Merged
m-bert merged 3 commits intomainfrom
@mbert/more-eslint
Apr 15, 2026
Merged

[eslint] Consistent import rules#4087
m-bert merged 3 commits intomainfrom
@mbert/more-eslint

Conversation

@m-bert
Copy link
Copy Markdown
Collaborator

@m-bert m-bert commented Apr 14, 2026 •
edited
Loading

Description

This PR aims to add new eslint rules, that:

  • Require sorted imports
  • Require type when importing only types

As there would be too many changes, I've decided to split this into two PRs. This one will be base, similarly as in monorepo migration.

Test plan

  • yarn lint-js
  • yarn ts-check
image

Copilot AI review requested due to automatic review settings April 14, 2026 12:39
@m-bert m-bert marked this pull request as draft April 14, 2026 12:39
@m-bert m-bert changed the title Consistent import rules [eslint] Consistent import rules Apr 14, 2026
Copilot AI reviewed Apr 14, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the repository’s root ESLint configuration to enforce more consistent TypeScript import/export patterns and import sorting, as a foundation for a larger import-cleanup effort across packages/apps.

Changes:

  • Enable @typescript-eslint/consistent-type-imports and @typescript-eslint/consistent-type-exports as errors.
  • Enable ESLint core sort-imports as an error.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .eslintrc.json
Comment thread .eslintrc.json
Comment thread .eslintrc.json
m-bert added 2 commits April 14, 2026 16:12
@m-bert
[eslint] Package (#4088)
f5591b3 
## Description

This PR fixes eslint errors in package after enabling new `import` rules

## Test plan

- `yarn ts-check`
- `yarn lint-js`

I've also run Sonnet to make sure that only `imports` were affected:

<img width="1018" height="289" alt="image"
src="https://github.com/user-attachments/assets/bdc7a858-ae67-4fc2-9152-cf12dc8cac38"
/>
@m-bert
[eslint] Apps (#4089)
66f6fa7 
## Description

This PR fixes eslint errors in package after enabling new import rules

>[!NOTE]
>`images.d.ts` was added because otherwise it is not possible to import
`*.png` as `import` statement.

## Test plan

- `yarn ts-check`
- `yarn lint-js`

<img width="1053" height="441" alt="image"
src="https://github.com/user-attachments/assets/e4490888-2484-4380-8bd3-92ee57a6ed97"
/>
@m-bert m-bert marked this pull request as ready for review April 14, 2026 14:19
@m-bert m-bert requested review from coado, Copilot and j-piasecki April 14, 2026 14:19
coado
coado approved these changes Apr 14, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@coado coado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow

Copilot AI reviewed Apr 14, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 299 out of 301 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread apps/common-app/src/common.tsx
Comment thread apps/common-app/src/common.tsx
j-piasecki
j-piasecki approved these changes Apr 15, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@j-piasecki j-piasecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ain't reading all that
happy for you though
or sorry it happened

Comment thread .eslintrc.json
"@typescript-eslint/no-unsafe-return": "warn",
"@typescript-eslint/no-non-null-assertion": "warn",
"@typescript-eslint/ban-types": "warn",
"@typescript-eslint/consistent-type-imports": "error",
Copy link
Copy Markdown
Member

@j-piasecki j-piasecki Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one I did read, and it looks fine

@m-bert m-bert merged commit 8e010d1 into main Apr 15, 2026
5 checks passed
@m-bert m-bert deleted the @mbert/more-eslint branch April 15, 2026 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@j-piasecki j-piasecki j-piasecki approved these changes

@coado coado coado approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@m-bert @j-piasecki @coado