[General] Don't activate buttons on start#4120
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts the default activation behavior for v3 “button” wrappers to avoid Android issues with nested buttons by no longer activating the underlying NativeViewGestureHandler immediately on touch start.
Changes:
- Set
shouldActivateOnStarttofalseforv3/componentsRawButton(and, transitively,BaseButton/RectButton/BorderlessButtonbuilt on it).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was changed in #4036 in order to get rid of strange platform dependent workarounds in buttons.
Probably. I think in that case we should also check if we should swap |
Do we want to do that in the buttons given, which are deprecated (and this will likely result in a behavior change)? |
m-bert
left a comment
There was a problem hiding this comment.
Do we want to do that in the buttons given, which are deprecated (and this will likely result in a behavior change)?
If they work correctly after this, then we don't have to change it. I've looked at examples and they seem work (at least in case of callbacks) so I guess we can ship it ![]()
Description
Changes
shouldActivateOnStarton buttons tofalse-truebreaks nested buttons on Android.cc @m-bert - I don't recall why it was
truein the first place, any chance that after #4116 it wouldn't have been needed anyway?Test plan
Screen.Recording.2026-04-24.at.14.34.36.mov
Screen.Recording.2026-04-24.at.14.34.17.mov