[iOS] Fix LegacyPressable not emitting onPressOut#4121
Merged
j-piasecki merged 1 commit intomainfrom Apr 27, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an iOS-specific LegacyPressable press lifecycle issue where onPressOut could fail to fire due to the state machine resetting on an unexpected NATIVE_START event, and keeps the v3 Pressable implementation aligned with the updated state machine expectations.
Changes:
- Add
NATIVE_STARTto the iOS Pressable state machine definition so the event no longer causes a reset mid-sequence. - Update v3
Pressableto dispatchNATIVE_STARTon iOS (still excluded on Android due to the existing hitSlop issue).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/react-native-gesture-handler/src/v3/components/Pressable.tsx | Dispatches NATIVE_START for iOS to match the state machine’s expected event sequence. |
| packages/react-native-gesture-handler/src/components/Pressable/stateDefinitions.ts | Updates iOS state sequence to include NATIVE_START, preventing iOS from getting stuck before FINALIZE. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
m-bert
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the
LegacyPressableon iOS getting stuck due to an unhandledNATIVE_STARTevent. Updates the non-legacy implementation to also dispatch theNATIVE_START, which is now expected by the state machine.Test plan
Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-04-27.at.07.52.42.mov
Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-04-27.at.07.52.29.mov