[iOS] Prevent duplicated events in Native gesture handling#4125
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent duplicate ACTIVE/update events being emitted by iOS native gesture handling (particularly for NativeView-based handling when not attached to a UIControl), aligning behavior with the approach from #4102.
Changes:
- Added an overridable
shouldSuppressActiveEvent:hook toRNGestureHandlerand applied it duringACTIVEevent dispatch. - Implemented suppression logic in
RNNativeViewGestureHandlerby comparingextraData.datato the last emitted active payload. - Moved
_lastActiveExtraDatacleanup toresetto ensure suppression state is cleared between gestures.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/react-native-gesture-handler/apple/RNGestureHandler.mm | Adds a suppression hook and uses it to early-return for duplicate ACTIVE events. |
| packages/react-native-gesture-handler/apple/RNGestureHandler.h | Exposes the new suppression hook in the base handler interface. |
| packages/react-native-gesture-handler/apple/Handlers/RNNativeViewHandler.mm | Implements duplicate suppression for NativeView handling and resets suppression state in reset. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
j-piasecki
approved these changes
Apr 28, 2026
Comment on lines
+341
to
+345
| - (void)reset | ||
| { | ||
| [super reset]; | ||
| _lastActiveExtraData = nil; | ||
| } |
Member
There was a problem hiding this comment.
Just to be sure, but this is called when attached to UIControls, right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I've noticed that when
Nativegesture is not attached toUIControlit sends different events (e.g. events containingxandypositions). I've changed that to mimic behavior from #4102Test plan
Tested on the following example