Skip to content

[General] Change Touchable callback order #4126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
j-piasecki merged 2 commits into from
Apr 28, 2026
+5 −11
Merged

[General] Change Touchable callback order #4126

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2476d1
Change callback order
j-piasecki Apr 28, 2026
49a0ba5
Review changes
j-piasecki Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions packages/react-native-gesture-handler/src/v3/components/Touchable/Touchable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,19 +89,14 @@ export const Touchable = (props: TouchableProps) => {
}
}, []);

const onDeactivate = useCallback(
(e: EndCallbackEventType) => {
if (!e.canceled && !longPressDetected.current && e.pointerInside) {
onPress?.(e);
}
},
[onPress]
);

const onFinalize = useCallback(
(e: EndCallbackEventType) => {
if (pointerState.current === PointerState.INSIDE) {
onPressOut?.(e);

if (!e.canceled && !longPressDetected.current) {
onPress?.(e);
}
Comment thread
j-piasecki marked this conversation as resolved.
Outdated
Comment thread
j-piasecki marked this conversation as resolved.
Outdated
}

pointerState.current = PointerState.UNKNOWN;
Expand Down Expand Up @@ -157,7 +152,6 @@ export const Touchable = (props: TouchableProps) => {
enabled={!disabled}
onBegin={onBegin}
onActivate={onActivate}
onDeactivate={onDeactivate}
onFinalize={onFinalize}
onUpdate={onUpdate}
defaultOpacity={defaultOpacity}
Expand Down
Loading