[iOS] Handle view recycling in Touchable#4131
Merged
j-piasecki merged 2 commits intoApr 30, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes incorrect visual defaults when Touchable/native button views are reused under Fabric view recycling, ensuring recycled instances return to a clean animation/press state and re-apply default visual props correctly.
Changes:
- Add explicit recycle-time reset hooks for the Fabric button component view and the underlying native button.
- Force a one-shot re-application of the idle (“start animation”) state after recycling to ensure
default*props are applied. - Preserve wrapper-layer opacity across
finalizeUpdatesto avoid React re-renders clobbering press/idle visuals.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/react-native-gesture-handler/apple/RNGestureHandlerButtonComponentView.mm | Adds prepareForRecycle, tracks recycle state to re-apply idle visuals, and snapshots/restores wrapper-layer opacity in finalizeUpdates. |
| packages/react-native-gesture-handler/apple/RNGestureHandlerButton.mm | Adds prepareForRecycle to cancel pending animations/blocks and reset transient press visual state (transform/alpha/underlay). |
| packages/react-native-gesture-handler/apple/RNGestureHandlerButton.h | Exposes prepareForRecycle API with documentation for Fabric recycling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
j-piasecki
deleted the
@jpiasecki/ios-fix-touchable-default-props-recycling
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Due to the Fabric view recycling not being handled correctly by the native button implementations, the
default*props were not applied correctly when the button instances were being reused. This presented itself by buttons being styled correctly on the first mount, but not during the following ones.This PR addresses that.
Test plan
Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-04-29.at.12.02.29.mov
Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-04-29.at.12.01.17.mov