Skip to content

[iOS] Remove a redundant detachHandlerWithTag definition#4132

Merged
j-piasecki merged 1 commit into
mainfrom
@jpiasecki/remove-redundant-def
Apr 30, 2026
Merged

[iOS] Remove a redundant detachHandlerWithTag definition#4132
j-piasecki merged 1 commit into
mainfrom
@jpiasecki/remove-redundant-def

Conversation

@j-piasecki
Copy link
Copy Markdown
Member

Description

Removes redundant detachHandlerWithTag definition, which was never used and never implemented. Most likely a result of a merge commit.

Test plan

Compile the app

Copilot AI review requested due to automatic review settings April 29, 2026 10:07
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes an unused and unimplemented Objective-C method declaration from the iOS gesture handler registry header to avoid exposing redundant API surface (likely introduced by a merge).

Changes:

  • Deleted the redundant -detachHandlerWithTag: declaration from RNGestureHandlerRegistry.h, keeping the implemented -detachHandlerWithTag:fromHostDetector: API.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@j-piasecki j-piasecki requested a review from m-bert April 29, 2026 10:23
@j-piasecki j-piasecki merged commit 358b57c into main Apr 30, 2026
7 checks passed
@j-piasecki j-piasecki deleted the @jpiasecki/remove-redundant-def branch April 30, 2026 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants