Skip to content

[iOS] Fix enabled state diverging between the handler and its recognizer #4140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
j-piasecki merged 1 commit into from
May 4, 2026
+1 −14
Merged

[iOS] Fix enabled state diverging between the handler and its recognizer #4140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/react-native-gesture-handler/apple/Handlers/RNPanHandler.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,6 @@ - (void)reset
[self triggerActionFromReset];
[_gestureHandler.pointerTracker reset];
[NSObject cancelPreviousPerformRequestsWithTarget:self selector:@selector(activateAfterLongPress) object:nil];
self.enabled = YES;
[super reset];
[_gestureHandler reset];

Expand Down
2 changes: 1 addition & 1 deletion packages/react-native-gesture-handler/apple/Handlers/RNTapHandler.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ - (void)reset
[NSObject cancelPreviousPerformRequestsWithTarget:self selector:@selector(cancel) object:nil];
_tapsSoFar = 0;
_maxNumberOfTouches = 0;
self.enabled = YES;
self.enabled = _gestureHandler.enabled;
[super reset];
[_gestureHandler reset];
}
Expand Down
12 changes: 0 additions & 12 deletions packages/react-native-gesture-handler/apple/RNRootViewGestureRecognizer.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,18 +33,6 @@ - (instancetype)init
return self;
}

- (BOOL)shouldBeRequiredToFailByGestureRecognizer:(UIGestureRecognizer *)otherGestureRecognizer
{
// This method is used to implement "enabled" feature for gesture handlers. We enforce gesture
// recognizers that are connected with "disabled" handlers to wait for the root gesture
// recognizer to fail and this way we block them from acting.
RNGestureHandler *otherHandler = [RNGestureHandler findGestureHandlerByRecognizer:otherGestureRecognizer];
if (otherHandler != nil && otherHandler.enabled == NO) {
return YES;
}
return NO;
}

- (BOOL)canPreventGestureRecognizer:(UIGestureRecognizer *)preventedGestureRecognizer
{
return ![preventedGestureRecognizer isKindOfClass:[RCTSurfaceTouchHandler class]];
Expand Down
Loading