Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent calling prepareConfig multiple times for the same gesture config object, avoiding react-native-worklets warnings caused by the config being frozen after being sent to native.
Changes:
- Replace the one-time memoization of
disableReanimatedwith memoization of the initialconfigobject. - Add a guard intended to skip repeated
prepareConfig(config)calls when the config hasn’t changed.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+48
to
+50
| if (config !== previousConfig) { | ||
| prepareConfig(config); | ||
| } |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Calling
preapreConfigmultiple times with the same config object results in warning fromreact-native-worklets, as the config object is frozen once it is passed to the native side (e.g.bindSharedValues)I've used similar technique as with
disableReanimated- memoize config and check whether it has changed. If not - there's no need to callprepareConfigagain.Test plan
Tested on the repro app.