fix(pods): Fix invalid react-native/../react-native resolution for aliases (#9592)

## Description

Related:
software-mansion/react-native-gesture-handler#4232
(same fix for `react-native-gesture-handler`)

The pod scripts attempt to resolve `react-native/package.json` to get to
the `version` and perform a version check. It however performs a
redundant `react-native/../react-native` resolution i.e. it essentially
performs `path.dirname(require.resolve('react-native/package.json'))`
(correct), but then joins this with `${dir}/..`, then re-joins this with
`react-native`.

Re-entering the `react-native` directory can be invalid in case of
symlinks in the `node_modules` structure. The easiest way to reproduce
an issue is to use react-native-tvos's pattern of aliasing
`"react-native": "npm:react-native-tvos@x.x.x"`. With isolated
dependencies this will point a symlink at a directory that's named
`react-native-tvos` and not `react-native`. The also applies to local
`link:` dependency specifiers. Essentially, the directory name
`react-native` is unnecessarily enforced.

This would lead to a cryptic `file: no implicit conversion of nil into
String.` error

## Test plan

- Existing `pod install` in working projects should continue passing
unchanged
-
https://github.com/kitten/douglowder--with-monorepo-tv-test/tree/init-pnpm
- `pnpm i` then in `apps/tv` run `pnpm prebuild` (which runs `pod
install`)

---------

Co-authored-by: Tomasz Żelawski <tzelawski@gmail.com>

Author: kitten

packages/react-native-reanimated/scripts/reanimated_utils.rb

@@ -1,8 +1,8 @@
 module ReanimatedUtils
   module_function
 
-  def try_to_parse_react_native_package_json(node_modules_dir)
-    react_native_package_json_path = File.join(node_modules_dir, 'react-native/package.json')
+  def try_to_parse_react_native_package_json(react_native_dir)
+    react_native_package_json_path = File.join(react_native_dir, 'package.json')
     if !File.exist?(react_native_package_json_path)
       return nil
     end
@@ -13,17 +13,17 @@ def find_config()
     result = {
       :is_reanimated_example_app => nil,
       :react_native_version => nil,
-      :react_native_node_modules_dir => nil,
+      :react_native_dir => nil,
       :react_native_common_dir => nil,
     }
 
-    react_native_node_modules_dir = File.join(File.dirname(`cd "#{Pod::Config.instance.installation_root.to_s}" && node --print "require.resolve('react-native/package.json')"`), '..')
-    react_native_json = try_to_parse_react_native_package_json(react_native_node_modules_dir)
+    react_native_dir = File.dirname(`cd "#{Pod::Config.instance.installation_root.to_s}" && node --print "require.resolve('react-native/package.json')"`)
+    react_native_json = try_to_parse_react_native_package_json(react_native_dir)
 
     if react_native_json == nil
       # user configuration, just in case
       node_modules_dir = ENV["REACT_NATIVE_NODE_MODULES_DIR"]
-      react_native_json = try_to_parse_react_native_package_json(node_modules_dir)
+      react_native_json = try_to_parse_react_native_package_json(File.join(node_modules_dir, 'react-native'))
     end
 
     if react_native_json == nil
@@ -38,10 +38,10 @@ def find_config()
 
     result[:is_reanimated_example_app] = ENV["IS_REANIMATED_EXAMPLE_APP"] != nil
     result[:react_native_version] = react_native_json['version']
-    result[:react_native_node_modules_dir] = File.expand_path(react_native_node_modules_dir)
+    result[:react_native_dir] = File.expand_path(react_native_dir)
 
     pods_root = Pod::Config.instance.project_pods_root
-    react_native_common_dir_absolute = File.join(react_native_node_modules_dir, 'react-native', 'ReactCommon')
+    react_native_common_dir_absolute = File.join(react_native_dir, 'ReactCommon')
     react_native_common_dir_relative = Pathname.new(react_native_common_dir_absolute).relative_path_from(pods_root).to_s
     result[:react_native_common_dir] = react_native_common_dir_relative
 

packages/react-native-worklets/scripts/worklets_utils.rb

@@ -1,8 +1,8 @@
 module WorkletsUtils
   module_function
 
-  def try_to_parse_react_native_package_json(node_modules_dir)
-    react_native_package_json_path = File.join(node_modules_dir, 'react-native/package.json')
+  def try_to_parse_react_native_package_json(react_native_dir)
+    react_native_package_json_path = File.join(react_native_dir, 'package.json')
     if !File.exist?(react_native_package_json_path)
       return nil
     end
@@ -15,17 +15,17 @@ def find_config()
       :fetch_preview_flag => nil,
       :is_reanimated_example_app => nil,
       :react_native_version => nil,
-      :react_native_node_modules_dir => nil,
+      :react_native_dir => nil,
       :react_native_common_dir => nil,
     }
 
-    react_native_node_modules_dir = File.join(File.dirname(`cd "#{Pod::Config.instance.installation_root.to_s}" && node --print "require.resolve('react-native/package.json')"`), '..')
-    react_native_json = try_to_parse_react_native_package_json(react_native_node_modules_dir)
+    react_native_dir = File.dirname(`cd "#{Pod::Config.instance.installation_root.to_s}" && node --print "require.resolve('react-native/package.json')"`)
+    react_native_json = try_to_parse_react_native_package_json(react_native_dir)
 
     if react_native_json == nil
       # user configuration, just in case
       node_modules_dir = ENV["REACT_NATIVE_NODE_MODULES_DIR"]
-      react_native_json = try_to_parse_react_native_package_json(node_modules_dir)
+      react_native_json = try_to_parse_react_native_package_json(File.join(node_modules_dir, 'react-native'))
     end
 
     if react_native_json == nil
@@ -34,10 +34,10 @@ def find_config()
 
     result[:is_reanimated_example_app] = ENV["IS_REANIMATED_EXAMPLE_APP"] != nil
     result[:react_native_version] = react_native_json['version']
-    result[:react_native_node_modules_dir] = File.expand_path(react_native_node_modules_dir)
+    result[:react_native_dir] = File.expand_path(react_native_dir)
 
     pods_root = Pod::Config.instance.project_pods_root
-    react_native_common_dir_absolute = File.join(react_native_node_modules_dir, 'react-native', 'ReactCommon')
+    react_native_common_dir_absolute = File.join(react_native_dir, 'ReactCommon')
     react_native_common_dir_relative = Pathname.new(react_native_common_dir_absolute).relative_path_from(pods_root).to_s
     result[:react_native_common_dir] = react_native_common_dir_relative