Commit b19e2a1
authored
fix: CSS transitions not working when a prop is added or removed (#9014)
## Summary
I introduced a foolish bug in #8982 while migrating from the
`folly::dynamic` to the `jsi::Value` usage as I forgot to update
`isNull()` checks to `isUndefined()` (undefined values were
automatically converted to nulls in `folly::dynamic` so we had to use
`isNull` before).
## Example recordings
| Before | After |
|-|-|
| <video
src="https://github.com/user-attachments/assets/32947faa-b0f8-4f72-80ee-5df2878caf38"
/> | <video
src="https://github.com/user-attachments/assets/146da9e1-cafc-4751-b03b-434c681ece81"
/> |
It also displayed this warning before:
<img width="1199" height="329" alt="Screenshot 2026-02-26 at 01 04 16"
src="https://github.com/user-attachments/assets/254110b1-3f04-45f5-95d8-ea6c92a852b0"
/>1 parent abb8469 commit b19e2a1
2 files changed
Lines changed: 9 additions & 9 deletions
File tree
- apps/fabric-example/ios
- packages/react-native-reanimated/Common/cpp/reanimated/CSS/interpolation/values
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
54 | | - | |
55 | | - | |
| 54 | + | |
| 55 | + | |
56 | 56 | | |
57 | 57 | | |
58 | 58 | | |
| |||
0 commit comments