App crashes when using lots of animated styles

[diogoquintas]

Description

When rendering a considerable amount of components that use reanimated, the app crashes with EXC_BAD_ACCESS on reanimated::RuntimeDecorator::decorateUIRuntime.

report

The issue also happens with fewer elements but it's more difficult to reproduce.
This does not happen when using the last stable version (2.13.0), although the performance seems to be worse.

Steps to reproduce

Just opening the app, it consistently crashes even without interaction.

Snack or a link to a repository

https://github.com/diogoquintas/reanimated-example

Reanimated version

3.0.0-rc.8

React Native version

0.70.1

Platforms

iOS

JavaScript runtime

Hermes

Workflow

React Native (without Expo)

Architecture

Paper (Old Architecture)

Build type

Debug mode

Device

iOS simulator

Device model

iPhone 14

Acknowledgements

Yes

[tomekzaw]

Hey @diogoquintas, thanks for reporting this issue.

It seems like the offending commit is c8a77da. It would be very appreciated if you could revert these changes manually in your node_modules and confirm that it resolves the issue.

If this succeeds, the plan is to revert c8a77da (which will break error handling in runOnUI), merge #3846 (which should fix it) and then release 3.0.0-rc.9.

This does not happen when using the last stable version (2.13.0), although the performance seems to be worse.

The issue is related to the new implementation of shared values which we released only in v3-rc in order to collect the feedback from the community so thanks again for spotting and reporting the bug! Despite the crash, we are happy that you can see the performance improvement in 3.0.0-rc.8 compared to v2.

Edit: should be fixed with #3859

[diogoquintas]

It seems like the offending commit is c8a77da. It would be very appreciated if you could revert these changes manually in your node_modules and confirm that it resolves the issue.

Although it seems to fix the issue on iOS, the app crashes when booting on Android.

Probably this is not related to the initial issue because there's no error, the app is killed by using too much resources.
In the repo provided, I can find a sweet spot of items to render that work in version 2.10.0 but crashes in 3.0.0-rc.8.
Could it just be a performance downgrade in Android or some other issue?

I took a look at this issue because it looks similar and tried running with the changes from #3852 but to no avail.

[graszka22]

So it's fixed on iOS.
On my Android device it works too, though slowly and takes about ~2gb of memory according to android studio profiler. But I guess it's expected with 10000 animated views.

[diogoquintas]

Yes, the initial issue is fixed.

The other issue I mentioned (happening on Android) seems to be more related to performance than an error itself.
The version 3.0.0-rc.8 is supposed to be faster but in that example is the other way around.

With that said, we can probably close this issue.