feat: Add support for compound registry keys in css#8969
Merged
Conversation
Contributor
Author
|
I believe more tests should be added but I don't really know where to put them. Suggestions are welcome :> |
tjzel
reviewed
Feb 25, 2026
tjzel
left a comment
tjzel
left a comment
Collaborator
There was a problem hiding this comment.
Looks good overall but I'm a bit worried about redundancy and transparency:
- I don't really find
reactViewNameandjsComponentNamedistinct enough, can we make their names more explicit? - We seem to pass both
reactViewNameandjsComponentNamequite often, recreating the compound name from them in several places. Can't we always just use the compound name?
…figs/common.h Co-authored-by: Tomasz Żelawski <40713406+tjzel@users.noreply.github.com>
tjzel
approved these changes
Feb 26, 2026
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Feb 27, 2026
## Summary PR adds SVG Polyline CSS Property which enables animation of SVG Polyline. ## Test plan You can play with prepared examples: Run fabric-example -> CSS -> Animated Properties -> SVG Properties -> Polyline Requires [#8969](#8969) --------- Co-authored-by: Mateusz Łopaciński <lop.mateusz.2001@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently props builders in CSS are selected based on componentName of the element, which is problematic since there are cases where two different props builders can be needed for two elements with identical
reactViewNamebut differentjsComponentName(e.g.RSVGPath(reactViewName) is used by different JS components, such asPolylineandPolygon(jsComponentName)). This PR fixes that by adding support for creation of compound keys (reactViewName+ delimiter +jsComponentName). This works as a "specialization" mechanism for the registry keys -- if thejsComponentNameisn't provided or there is no props builder forreactViewName+ delimiter +jsComponentNamekey, then the behavior defaults to the old one (reactViewNameused as a key).This PR also makes necessary changes in the animation keyframes registry (both JS and C++) as the same keyframes object can give different results after normalization (
getNormalizedKeyframesConfigcall) for differentreactViewNameandjsComponentName- using justreactViewNameis not enough as different variations ofreactViewName+ delimiter +jsComponentNamemay use different prop builders that give different results.Test plan
Some new tests were added and existing ones were updated.