Skip to content

feat: Support % length values in SVG CSS animations#9011

Merged
MatiPl01 merged 4 commits into
mainfrom
@matipl01/replace-svg-length-with-css-length
Feb 27, 2026
Merged

feat: Support % length values in SVG CSS animations#9011
MatiPl01 merged 4 commits into
mainfrom
@matipl01/replace-svg-length-with-css-length

Conversation

@MatiPl01

@MatiPl01 MatiPl01 commented Feb 25, 2026

Copy link
Copy Markdown
Member

Summary

There was an issue with propagation of SVG dimensions before, which was finally fixed in this PR. Thanks to these changes, we are able to support % in the same way as for non-svg components and don't have to use the separate value struct SVGLength.

Test plan

I went through all SVG-related examples in the example app, adjusted descriptions stating that % aren't supported (which isn't true anymore) and tested that everything works as expected now.

@MatiPl01
MatiPl01 removed the request for review from tjzel February 25, 2026 17:02
@MatiPl01
MatiPl01 marked this pull request as draft February 25, 2026 17:02
@MatiPl01
MatiPl01 marked this pull request as ready for review February 25, 2026 20:00

@wisniewskij wisniewskij left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread apps/common-app/package.json
@MatiPl01
MatiPl01 added this pull request to the merge queue Feb 27, 2026
Merged via the queue into main with commit d82a03d Feb 27, 2026
23 checks passed
@MatiPl01
MatiPl01 deleted the @matipl01/replace-svg-length-with-css-length branch February 27, 2026 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants