fix: CSS transitions not working when a prop is added or removed#9014
Merged
Conversation
tjzel
approved these changes
Feb 26, 2026
MatiPl01
deleted the
@matipl01/fix-css-transitions-with-missing-props
branch
February 27, 2026 06:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I introduced a foolish bug in #8982 while migrating from the
folly::dynamicto thejsi::Valueusage as I forgot to updateisNull()checks toisUndefined()(undefined values were automatically converted to nulls infolly::dynamicso we had to useisNullbefore).Example recordings
Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-02-25.at.03.21.49.mp4
Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-02-26.at.00.58.42.mp4
It also displayed this warning before: