fix: Add missing jsitooling dependency to podspecs#9049
Closed
gabrieldonadel wants to merge 1 commit into
Closed
Conversation
3 tasks
Member
|
Hey @gabrieldonadel, thanks for submitting this PR! Looks like we already have a PR from @tjzel that does a similar thing (#9035) |
Contributor
Author
Ohh great! let me close this one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In react-native 0.84 some of the common JSI binding utils were moved to jsitooling (react/react-native#54406), requiring
jsitoolingto be declared as a dependency in podspec to ensure headers can be found.When using reanimated 4.2.2, building iOS release and not using precompiled React Native will result in the following error
Test plan
Run fabric-example locally and run in Expo's repo