Skip to content

fix: Add missing jsitooling dependency to podspecs#9049

Closed
gabrieldonadel wants to merge 1 commit into
software-mansion:mainfrom
gabrieldonadel:@gabrieldonadel/fix-jsi-tooling
Closed

fix: Add missing jsitooling dependency to podspecs#9049
gabrieldonadel wants to merge 1 commit into
software-mansion:mainfrom
gabrieldonadel:@gabrieldonadel/fix-jsi-tooling

Conversation

@gabrieldonadel

Copy link
Copy Markdown
Contributor

Summary

In react-native 0.84 some of the common JSI binding utils were moved to jsitooling (react/react-native#54406), requiring jsitooling to be declared as a dependency in podspec to ensure headers can be found.

When using reanimated 4.2.2, building iOS release and not using precompiled React Native will result in the following error

In file included from /Users/gabriel/Desktop/expo/node_modules/react-native-worklets/Common/cpp/worklets/WorkletRuntime/WorkletRuntimeDecorator.cpp:6:
In file included from /Users/gabriel/Desktop/expo/node_modules/react-native-worklets/Common/cpp/worklets/WorkletRuntime/WorkletRuntime.h:5:
/Users/gabriel/Desktop/expo/node_modules/react-native/ReactCommon/jsiexecutor/jsireact/JSIExecutor.h:15:10: fatal error: 'react/runtime/JSRuntimeBindings.h'
      file not found
   15 | #include <react/runtime/JSRuntimeBindings.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/gabriel/Desktop/expo/node_modules/react-native/ReactCommon/jsiexecutor/jsireact/JSIExecutor.h:15:10: note: did not find header
      'runtime/JSRuntimeBindings.h' in framework 'react' (loaded from
      '/Users/gabriel/Desktop/expo/apps/brownfield-tester/expo-app/ios/build/Build/Products/Debug-iphoneos/React-Core')
1 error generated.

Test plan

Run fabric-example locally and run in Expo's repo

@tomekzaw

tomekzaw commented Mar 3, 2026

Copy link
Copy Markdown
Member

Hey @gabrieldonadel, thanks for submitting this PR!

Looks like we already have a PR from @tjzel that does a similar thing (#9035)

@gabrieldonadel

Copy link
Copy Markdown
Contributor Author

Hey @gabrieldonadel, thanks for submitting this PR!

Looks like we already have a PR from @tjzel that does a similar thing (#9035)

Ohh great! let me close this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants