Extract applySynchronousUpdates from performOperations#9078
Merged
bartlomiejbloniarz merged 1 commit intoMar 11, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extracts the synchronous UI props update logic from the performOperations method into a dedicated applySynchronousUpdates method. It also introduces two helper functions: shouldUseSynchronousUpdatesInPerformOperations (compile-time feature flag check) and partitionUpdates (splits props into synchronous and shadow tree batches).
Changes:
- Added
shouldUseSynchronousUpdatesInPerformOperations()as aconstexprfunction in an anonymous namespace, consolidating the platform-specific feature flag checks that were previously inlineif constexprblocks. - Added
partitionUpdates()to separate update batches into synchronous and shadow tree props, replacing the inline partitioning logic that previously existed in both Android and iOS codepaths. - Extracted the Android and iOS synchronous update application logic into the new
applySynchronousUpdatesmember method.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
ReanimatedModuleProxy.h |
Declares the new applySynchronousUpdates private method. |
ReanimatedModuleProxy.cpp |
Adds shouldUseSynchronousUpdatesInPerformOperations, partitionUpdates helpers and applySynchronousUpdates method; refactors performOperations to use them. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bartlomiejbloniarz
force-pushed
the
@bartlomiejbloniarz/extract-apply-synchronous-updates
branch
2 times, most recently
from
ea4bdef to
8b85857
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tomekzaw
approved these changes
Mar 11, 2026
bartlomiejbloniarz
deleted the
@bartlomiejbloniarz/extract-apply-synchronous-updates
branch
bartlomiejbloniarz
added a commit
that referenced
this pull request
Mar 18, 2026
## Summary Separates the synchronous UI props update logic into its own `applySynchronousUpdates` method. Adds `partitionUpdates` and `shouldUseSynchronousUpdatesInPerformOperations` helpers to support the extracted method. ## Test plan
bartlomiejbloniarz
added a commit
that referenced
this pull request
Mar 18, 2026
## Summary Separates the synchronous UI props update logic into its own `applySynchronousUpdates` method. Adds `partitionUpdates` and `shouldUseSynchronousUpdatesInPerformOperations` helpers to support the extracted method. ## Test plan
bartlomiejbloniarz
added a commit
that referenced
this pull request
Mar 18, 2026
Separates the synchronous UI props update logic into its own `applySynchronousUpdates` method. Adds `partitionUpdates` and `shouldUseSynchronousUpdatesInPerformOperations` helpers to support the extracted method.
bartlomiejbloniarz
added a commit
that referenced
this pull request
Mar 20, 2026
bartlomiejbloniarz
added a commit
that referenced
this pull request
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Separates the synchronous UI props update logic into its own
applySynchronousUpdatesmethod.Adds
partitionUpdatesandshouldUseSynchronousUpdatesInPerformOperationshelpers to support the extracted method.Test plan