Make clang-tidy work in parallel#9108
Merged
Merged
Conversation
Contributor
Author
|
After this is merged we have to check if it works properly with the CI (if the run-clang-tidy script can be run by the CI). Also merged commit should be included in |
wisniewskij
force-pushed
the
@wisniewskij/make-clangtidy-work-in-parallel
branch
from
02a2888 to
3a8cf58
Compare
wisniewskij
commented
Mar 16, 2026
Contributor
Author
|
Just run the lint-clang-tidy workflow on this branch and it passed. Now I will push a commit that should make it fail. |
wisniewskij
force-pushed
the
@wisniewskij/make-clangtidy-work-in-parallel
branch
from
4e0310c to
0685361
Compare
This reverts commit 0685361.
Contributor
Author
|
It failed as expected. Now It's ready for review. |
MatiPl01
reviewed
Mar 17, 2026
MatiPl01
left a comment
MatiPl01
left a comment
Member
There was a problem hiding this comment.
Left some suggestions for possible improvements.
tjzel
approved these changes
Mar 18, 2026
tshmieldev
pushed a commit
that referenced
this pull request
Mar 24, 2026
## Summary Current clang-tidy configuration is painfully slow (because it runs synchronously on one thread) + from what I understand, passing .h files in a way it's currently done, is not suggested and it can cause some problems with errors not being displayed properly (some errors in .h files are displayed as warnings, which can cause problems). I changed the configuration to use "run-clang-tidy" script which enables us to fix both of those issues. Additionally I fixed all the issues that are now caught in the .h files by the script. ## Test plan in both `packages/react-native-worklets` and `packages/react-native-reanimated` run `yarn lint:clang-tidy` --------- Co-authored-by: Tomasz Żelawski <tzelawski@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Current clang-tidy configuration is painfully slow (because it runs synchronously on one thread) + from what I understand, passing .h files in a way it's currently done, is not suggested and it can cause some problems with errors not being displayed properly (some errors in .h files are displayed as warnings, which can cause problems).
I changed the configuration to use "run-clang-tidy" script which enables us to fix both of those issues. Additionally I fixed all the issues that are now caught in the .h files by the script.
Test plan
in both
packages/react-native-workletsandpackages/react-native-reanimatedrunyarn lint:clang-tidy