chore: bunch registration of pseudoselectors#9684
Merged
wisniewskij merged 4 commits intoJun 17, 2026
Merged
Conversation
wisniewskij
deleted the
@wisniewskij/pseudoselectors-default-props-refactor
branch
June 17, 2026 08:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes the way we call registration of the pseudoselectors. Previously we would pass default styles alongside "result" styles - so defaults would be provided by selector. This is bad because it can lead to redundancy - if we have a few pseudoselctors controlling one prop, we send the defaults a few times even though they are the same. Also previously registering a few pseudoselectors on a single tag would recompute the final styles for each of those.
After changes we support batch registration of pseudoselectors per tag - single defaults object per tag + a single pass of a list of result styles from js instead of many smaller calls.
Test plan
There should be no change in behavior in comparison to the previous implementation.