chore: Route CSS transitions in common with a single platform apply hook#9697
Closed
MatiPl01 wants to merge 1 commit into
Closed
Conversation
…y hook The platform layer previously exposed four hooks (canRoute, two value-blind apply paths, remove) and owned both parsing and the reverse-shortening state. Move all of that into CSSPlatformTransitionProxy: it now calls canRouteCSSProperty and parsePlatformValue directly, reverse-shortens interruptions, and owns the per-view in-flight transition state. The platform is left with a single parsing-free apply hook (animate a resolved value over a window) plus remove, so it only drives Core Animation. Collapses the holder's four css hooks to two (cssApplyTransition, cssRemoveTransition). Behavior is unchanged; the routing and reverse-shortening logic moved across the boundary verbatim.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unifies the CSS-transition platform-routing boundary. Previously the platform exposed four hooks (
canRoute, two value-blind apply paths,remove) and owned both the endpoint parsing and the reverse-shortening state. This moves all of that into the commonCSSPlatformTransitionProxy:canRouteCSSPropertyandparsePlatformValuedirectly (no hooks),cssApplyTransition(animate a resolved value over a window), pluscssRemoveTransition.So the holder's four css hooks collapse to two, and the iOS layer (
REACSSPlatformTransitions) only drives Core Animation now.Purpose
Localizes parsing, routing, and reverse-shortening in shared code, leaving the platform with pure native-animation orchestration. This is the foundation the transform-on-Core-Animation work will plug into (a transform-aware sibling of the same apply hook).
Test plan
CSSPlatformTransitionProxy.cppcompiles on Android (real NDK flags,-Werror -Wpedantic) and iOS (host clang, iOS headers).reverseShorten, and resolved duration/start handed to Core Animation), so behavior is unchanged.