fix: hold platform-routed CSS transition values in the updates registry#9809
Closed
MatiPl01 wants to merge 1 commit into
Closed
Conversation
Member
Author
|
Closing in favor of making the platform (Core Animation) transition persistent for pseudo selectors, which animates quick press/release correctly (partial animation + ease back) instead of applying the settled value instantly. New PR to follow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #9775.
On iOS, CSS properties routed to Core Animation recorded nothing in the updates registry, so the commit hook had nothing to re-apply over React's committed base value - once the native animation finished, the rendered value reclaimed the layer and a held
:activevalue snapped back to the render color.This records each platform-routed transition's target in the registry (both
runoverloads) so the commit hook keeps it applied over React's base. Uniform for all Core Animation transitions, no.mmchange, no-op on Android.Verified on the iOS simulator: the
:activebox holds across render commits with no flicker, ordinary transitions animate unchanged, and release resumes the render loop cleanly.