fix: make iOS Core Animation transitions persistent for pseudo selectors#9814
Closed
MatiPl01 wants to merge 3 commits into
Closed
Conversation
Contributor
|
I've incorporated this change in #9775 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #9775. Replaces #9809.
On iOS, CSS properties routed to Core Animation animate as a one-shot
CABasicAnimationthat self-removes on completion, after which the layer falls back to its model value — the value React keeps committing. So while:activeis held past the transition duration, the rendered base value reclaims the layer and the pseudo value snaps back.Since pseudo selectors always take priority, this makes their platform animation persistent (
fillMode = kCAFillModeBoth,removedOnCompletion = NO) so it keeps its presentation over React's re-commits. Regular render-driven transitions stay non-persistent and unchanged; no C++ change; no-op on Android.Verified on the iOS simulator:
:activeholds over the render loop with no flicker, and press/release animates in and eases back out instead of snapping to the settled value.